feat(pipeline): split PreFlight into granular setup steps (#302)#345
Open
ArthurCRodrigues wants to merge 4 commits into
Open
feat(pipeline): split PreFlight into granular setup steps (#302)#345ArthurCRodrigues wants to merge 4 commits into
ArthurCRodrigues wants to merge 4 commits into
Conversation
…SetupCommands steps Add the missing documentation files referenced in the pipeline README: - 04-file-check.md: File validation step docs - 04.1-asset-injection.md: Asset injection step docs - 04.2-setup-commands.md: Setup commands step docs These files resolve the broken links flagged by the Validate Documentation CI check.
ac9c576 to
ca70b49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The current
PreFlightStepwas a "god step" that handled file checks, asset injection, and setup commands all at once. This made it difficult to track granular failures and introduced coupling between different setup phases.Solution
PreFlightStepinto three single-purpose steps:FileCheckStep,AssetInjectionStep, andSetupCommandsStep.Stepabstract class to include acategoryproperty for better organization.Templateabstract class to allow templates to contribute setup requirements (required files and setup commands).build_pipelineto combine assignment-level and template-level setup configurations.PipelineExecutionSerializerandfeedback_generatorto support the new granular steps and provide detailed success/failure reporting.StepRegistryto handle the new steps and their conditional inclusion logic.SandboxManagerto handle Docker client initialization lazily, allowing the API to run in remote mode without requiring a local Docker socket.Further clarifications
PreFlightStepclass is still kept for compatibility but is no longer used in the default pipeline orchestration.PreFlightStep.Related issues
Closes #302
Checklist