Skip to content

Develop#1

Merged
Sl3nc merged 12 commits into
mainfrom
develop
Apr 11, 2026
Merged

Develop#1
Sl3nc merged 12 commits into
mainfrom
develop

Conversation

@Sl3nc

@Sl3nc Sl3nc commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings April 11, 2026 01:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the WebTech Network autograder demo configuration and aligns some student submission paths/content for automated grading via GitHub Actions.

Changes:

  • Reworked .github/autograder/criteria.json to reference submission/... paths and adjusted several checks/thresholds.
  • Simplified .github/autograder/feedback.json to the reporting-only configuration (general + default).
  • Updated submission/ artifacts (CSS link path, JS formatting/data), and removed placeholder files/pages.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
submission/styles.css Removes a responsiveness media query block and minor cleanup.
submission/index.html Updates stylesheet link to styles.css in the submission root.
submission/app.js Refactors data object formatting and keeps navigation to a details page.
submission/relatorio.md Removes a placeholder file.
submission/detalhes.html Deletes the details page entirely.
README.md Replaces template README with autograder demo documentation.
.github/autograder/feedback.json Replaces prior content with reporting configuration.
.github/autograder/criteria.json Updates grading tree, paths, and test parameters.
Comments suppressed due to low confidence (1)

submission/styles.css:109

  • The responsive @media block was removed, but the autograder criteria still includes a check_media_queries test for submission/styles.css. Re-add at least one @media rule (or update the criteria) so the assignment’s responsiveness requirement can pass.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"parameters": [
{ "name": "attribute", "value": "class" },
{ "name": "required_count", "value": 2 }
{ "name": "required_count", "value": 3 }

Copilot AI Apr 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required_count for has_attribute (class) is set to 3, but submission/index.html currently only has 2 class attributes (section.container and div.form-container). Either lower this to 2 or update the HTML to include a third class attribute so the test matches the submission.

Suggested change
{ "name": "required_count", "value": 3 }
{ "name": "required_count", "value": 2 }

Copilot uses AI. Check for mistakes.
"parameters": [
{ "name": "style", "value": "font-family" },
{ "name": "count", "value": 1 }
{ "name": "count", "value": 2 }

Copilot AI Apr 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has_style test requires font-family to appear 2 times in submission/styles.css, but the stylesheet currently declares font-family only once. Either reduce the expected count to 1 or add a second font-family declaration in the CSS.

Suggested change
{ "name": "count", "value": 2 }
{ "name": "count", "value": 1 }

Copilot uses AI. Check for mistakes.
Comment thread .github/autograder/criteria.json Outdated
"name": "check_project_structure",
"parameters": [
{ "name": "expected_structure", "value": "README.md" }
{ "name": "expected_structure", "value": "submission/README.md" }

Copilot AI Apr 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The criteria expects a submission/README.md to exist, but submission/ currently contains only app.js, index.html, and styles.css. Either add submission/README.md or change expected_structure to the correct path/file you intend to validate.

Suggested change
{ "name": "expected_structure", "value": "submission/README.md" }
{
"name": "expected_structure",
"value": [
"submission/index.html",
"submission/styles.css",
"submission/app.js"
]
}

Copilot uses AI. Check for mistakes.
Comment on lines 234 to 244
{
"file": "index.html",
"file": "submission/index.html",
"name": "has_class",
"parameters": [
{ "name": "class_names", "value": ["bg-*"] },
{
"name": "class_names",
"value": ["card"]
},
{ "name": "required_count", "value": 1 }
]
}

Copilot AI Apr 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test checks for class card in submission/index.html, but that class is only created dynamically in submission/app.js (the HTML file doesn’t include it). Either adjust the test to validate the right artifact (e.g., CSS selector or JS DOM creation) or add an element with class card to the HTML if that’s the intended requirement.

Copilot uses AI. Check for mistakes.
Comment thread .github/autograder/criteria.json Outdated
Comment on lines 328 to 334
{
"file": "all",
"name": "has_no_js_framework",
"parameters": [
{ "name": "html_file", "value": "detalhes.html" },
{ "name": "js_file", "value": "app.js" }
{ "name": "js_file", "value": "submission/app.js" }
]
}

Copilot AI Apr 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second has_no_js_framework test is missing the html_file parameter (the first one includes it). If the intention was to scan another HTML page (e.g., a detalhes page), pass html_file; otherwise remove this duplicated test to avoid schema/runner errors.

Copilot uses AI. Check for mistakes.
Comment thread submission/app.js Outdated
Comment on lines 52 to 57
const card = document.createElement("article");
card.className = "card";

const link = document.createElement("a");
link.href = `detalhes.html?id=${noticia.id}`;

Copilot AI Apr 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detalhes.html was removed from submission/, but the home page links still navigate to detalhes.html?id=..., which will 404. Either restore submission/detalhes.html or update the navigation to point to an existing page/route.

Copilot uses AI. Check for mistakes.
Comment thread README.md Outdated
Comment thread README.md
Comment on lines +57 to +62
uses: webtech-network/autograder@main
with:
template-preset: "webdev"
feedback-type: "default"
include-feedback: "true"
openai-key: ${{ secrets.ENGINE }}

Copilot AI Apr 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README’s workflow YAML snippet uses tab indentation, which is not valid YAML and may mislead readers trying to copy/paste it. Update the snippet to use spaces and correct indentation.

Suggested change
uses: webtech-network/autograder@main
with:
template-preset: "webdev"
feedback-type: "default"
include-feedback: "true"
openai-key: ${{ secrets.ENGINE }}
uses: webtech-network/autograder@main
with:
template-preset: "webdev"
feedback-type: "default"
include-feedback: "true"
openai-key: ${{ secrets.ENGINE }}

Copilot uses AI. Check for mistakes.
@Sl3nc Sl3nc merged commit 1a15dff into main Apr 11, 2026
1 check passed
@Sl3nc Sl3nc deleted the develop branch April 11, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants