Fix registration when useEmailAsLogin is true#176
Open
margori wants to merge 1 commit intowebvimark:masterfrom
Open
Fix registration when useEmailAsLogin is true#176margori wants to merge 1 commit intowebvimark:masterfrom
margori wants to merge 1 commit intowebvimark:masterfrom
Conversation
Contributor
Author
|
Bumping for a another review or definition. Thanks. |
Contributor
Author
|
Bump |
colesnic89
reviewed
Jun 14, 2021
| @@ -119,10 +120,6 @@ public function registerUser($performValidation = true) | |||
| $user->username = $this->username; | |||
There was a problem hiding this comment.
is it really necessary? the whole else block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I set
enableRegistration = trueanduseEmailAsLogin = truein config then try to register but had this exceptionDatabase Exception – yii\db\Exception SQLSTATE[HY000]: General error: 1364 Field 'username' doesn't have a default value The SQL being executed was: INSERT INTOuser(email,status,confirmation_token,registration_ip,auth_key,password_hash,created_at,updated_at) VALUES ('d@d.com', 0, 'KDsZuiL2sZRFY7tJiCnU7F-AKqpTOrYD_1502566426', '127.0.0.1', '87i6gDXQydakT53XgOWZT0tya7INq0go', '$2y$13$z3qDng4W4TBEwza28IcjV.zm59kHsTMDH4Y3O9D8.aRkQrKTFyUJu', 1502566430, 1502566430)so this is me fix to it.