feat: Symfony bundle packaging (Plan 3)#4
Merged
Conversation
…systems Address PR #4 review: - Add SymfonyVendor/DoctrineVendor deptrac layers so a core->framework dependency is a violation, not a silently-uncovered one. Backs ADR 0009's 'core framework-free' claim and strengthens adapter isolation. Verified: a core->Symfony import now fails deptrac. - Document that the default resolver/renderer ports require the security and translator subsystems, with the re-alias escape hatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes Plan 3 — makes
wedevelopnl/audit-loga working Symfony bundle. Builds on the merged core (Plan 1) and Doctrine adapter (Plan 2):AuditRenderercontract (framework-free core) +TranslatorAuditRendererwith a configurable translation domain.Infrastructure/Symfony):SecurityActorResolver,RequestOriginResolver,UuidIdentityGenerator,NullSubjectLabeller. Resolvers read ambient state at call time (worker-mode safe), proven by behavioural tests.DependencyInjection/{AuditLogExtension,Configuration}+services.php+AuditLogBundle. Pre-wires every port and prepends the Doctrine DBAL types + entity mapping (zero consumer config).Notable decisions / deviations from the plan
symfony/framework-bundlekept inrequire(your call) — it's pulled transitively by doctrine-bundle and not imported bysrc/, but kept to declare the full-stack Symfony 8 target.composer igorrunsigor-php --no-agent .— the plan assumed Igor would analyse theTestKernelvia its console agent, but a console-less bundle has nobin/console.--no-agentdoes a deterministic static scan ofsrc/. The plan's"igor": "igor"script was also corrected to the real binary name. Verified the gate has teeth (flags a stateful service, exit ≠ 0).debug=false+ atearDown()that popsFrameworkBundle's leaked globalErrorHandler, required by the project's strictfailOnRisky=true.symfony/phpunit-bridgewas deliberately not added — it would install its own deprecation handler and conflict withfailOnDeprecation.pouw.nlwithexample.comacross new and pre-existing test fixtures.->end(), dropped invalidauto_generate_proxy_classes).Verification (all green locally)
Each code task went through fresh-subagent implementation + two-stage review (spec compliance, then code quality).