fix: allow Symfony 8.1 by widening pinned constraints to ^8.0#6
Merged
Conversation
The require block pinned every Symfony component to 8.0.*, blocking installation on Symfony 8.1. Nothing justified the pin (CI runs a plain composer update and ADR 0009 targets "Symfony 8" generically), so widen to ^8.0 — the standard bundle convention, BC-safe across Symfony minors. Also align the dev constraints: symfony/security-bundle was pinned to 8.0.* and symfony/cache to ^7.2, so the bundle's own CI never exercised 8.1; both move to ^8.0. Full suite passes against Symfony 8.1.0.
Symfony 8.1 deprecated HttpKernel's BundleInterface, which TestKernel inherited via Kernel::registerBundles()'s @return phpdoc — tripping the phpstan deprecation rule once the bump pulled 8.1. Override the phpdoc to the concrete Bundle base class the test bundles extend: accurate (a narrow, not a widen), deprecation-free, and valid on both 8.0 and 8.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The bundle pinned every Symfony component in
requireto8.0.*, which prevents installation on Symfony 8.1.Fix
Widen the Symfony constraints from
8.0.*to^8.0(>=8.0 <9.0) — the standard Symfony bundle convention. This is BC-safe because Symfony does not break backwards compatibility across minor releases.Nothing justified the original pin:
composer update(no version matrix forcing 8.0).Also aligned the dev constraints so the bundle's own CI actually exercises 8.1:
symfony/security-bundle:8.0.*→^8.0symfony/cache:^7.2→^8.0(was lagging a major behind the rest)Verification
composer update "symfony/*"resolves cleanly to Symfony 8.1.0.