Widen IP address column#10
Open
zanbaldwin wants to merge 1 commit into
Open
Conversation
zanbaldwin
force-pushed
the
z/ipcol-width
branch
2 times, most recently
from
564bd07 to
1a39c4b
Compare
The ORM ipAddress column was length:39, but a valid IPv4-mapped IPv6 textual form is 45 characters and silently overflowed the column. Widen to 46 to include buffer. Add test to cover full 45-character IP address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ORM ipAddress column was length:39, but a valid IPv4-mapped IPv6 textual form is 45 characters and silently overflowed the column. Widen to 46 to include buffer. Add test to cover full 45-character IP address.