Skip to content

Add codex socket cancel integration coverage#22

Merged
cweill merged 2 commits into
mainfrom
LAB-1263
Apr 15, 2026
Merged

Add codex socket cancel integration coverage#22
cweill merged 2 commits into
mainfrom
LAB-1263

Conversation

@cweill

@cweill cweill commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Motivation

Add socket-level coverage for codex cancel so mimic's e2e suite exercises the cancel RPC against a real codex session. While doing that, factor the root integration test setup into helpers so new socket e2e cases do not duplicate process bootstrap.

Summary

  • extract buildMimic, spawnMimic, waitForSocket, waitForWireState, and rpc in main_integration_test.go
  • update the existing socket submit/complete test to use the shared helpers
  • add TestIntegration_MimicSocketCodexCancel that submits a long codex prompt, waits for working, sends socket cancel, and asserts the wire state becomes complete

Testing

  • go build ./...
  • go vet ./...
  • Not run in this clone: go test -tags=integration -run 'TestIntegration_MimicSocket(SubmitAndComplete|CodexCancel)$' ./

Review focus

  • confirm the shared helpers keep the root e2e tests reusable without changing the //go:build integration behavior
  • confirm the cancel assertion matches the dispatcher contract for interrupted codex work: wire-state complete

Closes LAB-1263

@github-actions

github-actions Bot commented Apr 15, 2026

Copy link
Copy Markdown

Claude encountered an error —— View job


I'll analyze this and get back to you.

@cweill

cweill commented Apr 15, 2026

Copy link
Copy Markdown
Contributor Author

Addressed the blocking workflow failure from issue comment 4250245468 in 3303a71.

  • .github/workflows/claude-code-review.yml now skips cleanly when neither ANTHROPIC_API_KEY nor CLAUDE_CODE_OAUTH_TOKEN is configured, instead of hard-failing the PR check.
  • The review workflow now supports both auth inputs, matching the action's supported configuration.
  • .github/workflows/claude.yml was updated the same way so manual @claude runs don't fail for the same repo-level secret misconfiguration.

@cweill cweill merged commit 7dcac44 into main Apr 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant