Conversation
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Contributor
Author
|
Addressed the blocking workflow failure from issue comment 4250245468 in 3303a71.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add socket-level coverage for codex cancel so mimic's e2e suite exercises the
cancelRPC against a real codex session. While doing that, factor the root integration test setup into helpers so new socket e2e cases do not duplicate process bootstrap.Summary
buildMimic,spawnMimic,waitForSocket,waitForWireState, andrpcinmain_integration_test.goTestIntegration_MimicSocketCodexCancelthat submits a long codex prompt, waits forworking, sends socketcancel, and asserts the wire state becomescompleteTesting
go build ./...go vet ./...go test -tags=integration -run 'TestIntegration_MimicSocket(SubmitAndComplete|CodexCancel)$' ./Review focus
//go:build integrationbehaviorcompleteCloses LAB-1263