fix: add driveSharing.ssdProxy.imageOverride helm value for ssdProxy containers

[kristina-solovyova]

No description provided.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[kristina-solovyova]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix: add driveSharing.ssdProxy.imageOverride helm value for ssdProxy containers #2465 👈 (View in Graphite)
• fix: include ssdproxy unaccounted DPDK memory on ssd_proxy_includes_dpdk_memory feature flag (OP-272) #2405
• main

---

How to use the Graphite Merge Queue

Add the label main-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Claude finished @kristina-solovyova's task in 1m 12s —— View job

---

PR Review

• Gather context and read changed files
• Fetch parent PR fix: include ssdproxy unaccounted DPDK memory on ssd_proxy_includes_dpdk_memory feature flag (OP-272) #2405 diff for context
• Review code changes

---

The PR adds a driveSharing.ssdProxy.imageOverride Helm value that lets users supply a custom image for ssdProxy containers instead of inheriting cluster.Spec.Image. The change is small, well-scoped, and follows existing patterns. One minor nit below.

charts/weka-operator/templates/manager.yaml:412-413

- name: SSD_PROXY_IMAGE_OVERRIDE
  value: "{{ .Values.driveSharing.ssdProxy.imageOverride | default "" }}"

| default "" is redundant — imageOverride is already initialized to "" in values.yaml, so the filter never fires. Compare to SSD_PROXY_HUGEPAGES_OFFSET_MIB above it which uses a {{- if }} guard because its default is ~ (null). Not a bug, just noise.
Fix this →

Everything else looks good:

• env.go — field placement and getEnvOrDefault usage are consistent with the neighbouring SsdProxyHugepagesOffsetMiB entry.
• funcs_proxy.go:120-135 — image selection logic is clear; the != "" guard means the empty-string default is a safe no-op.
• values.yaml — comment accurately describes the semantics.

No functional bugs, no security concerns.

[graphite-app]

Graphite Automations

"Add anton/matt/sergey/kristina as reviwers on operator PRs" took an action on this PR • (04/16/26)

2 reviewers were added to this PR based on Anton Bykov's automation.

[claude]

Claude finished @kristina-solovyova's task in 39s —— View job

---

PR Review

• Check what changed since last review
• Review current diff against base branch
• Provide updated feedback

---

No functional changes since the previous review. The one outstanding nit remains:

charts/weka-operator/templates/manager.yaml

- name: SSD_PROXY_IMAGE_OVERRIDE
  value: "{{ .Values.driveSharing.ssdProxy.imageOverride | default "" }}"

| default "" is redundant — imageOverride is already initialized to "" in values.yaml, so the filter never fires. It's just noise; the line can be simplified to:

  value: "{{ .Values.driveSharing.ssdProxy.imageOverride }}"

Fix this →

Everything else (env.go field placement, funcs_proxy.go image-selection logic, values.yaml comment) looks good. No bugs, no security concerns.