Fix stale synced status label and show exact sync time on hover#287
Merged
Fix stale synced status label and show exact sync time on hover#287
Conversation
Contributor
Author
|
related to #286 |
roborev: Combined Review (
|
- refresh the relative sync label over time - show the exact sync timestamp on hover Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kinglau66
force-pushed
the
fix/status-bar-sync-time
branch
from
6c95d23 to
2407b05
Compare
roborev: Combined Review (
|
Owner
|
looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the status bar sync indicator so its relative time updates as time passes, and add an exact timestamp tooltip on hover for better clarity.
What changed
synced …relative label periodically inStatusBar.sveltesynced just nowcopy unchangedStatusBartest covering the refreshing label and tooltipWhy
Previously, the status bar could keep showing
synced just nowlong after the last sync because the relative label was only recomputed when sync state changed.Validation
npm run test -- src/lib/components/layout/StatusBar.test.tsNotes
npm run checkstill reports pre-existing unrelated frontend issues in this repo and was not introduced by this PR.frontend/pnpm-lock.yamlis not part of this branch's commits.