(components) fix: incorrect InView delay calculation#452
Merged
Conversation
andrewrubin
requested review from
NicholasLancey,
consolecmnd,
liamegan,
marlonmarcello,
meteoratlas and
pravton
🦋 Changeset detectedLatest commit: 6b91cd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
andrewrubin
commented
May 6, 2025
Comment on lines
+58
to
63
| --duration: #{get-duration($i)}; | ||
| } | ||
|
|
||
| .staggerDuration#{$i} { | ||
| --stagger-duration: #{get-duration($i, 20)}; | ||
| --stagger-duration: #{get-duration($i)}; | ||
| } |
Member
Author
There was a problem hiding this comment.
These two lines were the culprit (passing 20 for the second arg). I ended up removing the second arg entirely though.
marlonmarcello
approved these changes
May 6, 2025
marlonmarcello
left a comment
marlonmarcello
left a comment
Member
There was a problem hiding this comment.
This makes total sense
andrewrubin
force-pushed
the
bugfix/in-view-delay-calculation
branch
from
06891e5 to
6b91cd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time tracking: https://wethecollective.teamwork.com/app/tasks/22769488
Description
Fixes an issue on the
get-durationSass function, where the delay was being calculated incorrectly. For example, passingdelay={8}should get you a delay of0.8s, but it was returning0.4s.Solution
$subdivisions) from this helper entirely, as it doesn't seem helpful. We never run into cases where we need to divide our inputs by any other increments than 10. It also just confuses the usage a bit.Additional Notes