feat: add keydown Enter support for clickable card#101
Open
saugatmalla wants to merge 1 commit into
Open
Conversation
Contributor
|
Tested this one locally on TCG here and all works as expected to me. @liamegan I've tagged you in this review too as you have probably worked more on this library than anyone else. @saugatmalla Let's hold off merge until Liam has taken a look too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for keydown
Enterto toggle the cardenlargefor theclickablecard. This also traps the tab focus when the card is enlarged.The original task is Teamwork