fix: --llms scoped to group doubles namespace in command names#95
Open
fix: --llms scoped to group doubles namespace in command names#95
Conversation
When running `cli group --llms`, the `prefix` array was passed both to build `scopedName` (e.g. "cli group") AND to the collect helper functions which also prepend it to each command name. This caused output like: `cli group group login` instead of `cli group login` The fix passes an empty prefix to collect helpers when scoped, since `scopedName` already carries the group path for display. Affects --llms, --llms-full in md/json/yaml formats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
--llms(or--llms-full) scoped to a command group, the group segment is duplicated in command names:Expected:
Actual:
This affects all output formats (md, json, yaml) for both
--llmsand--llms-full.With nested groups the duplication compounds — e.g.
app project deploy project deploy createinstead ofapp project deploy create.Cause
In
Cli.ts, the scoping loop (lines 572–588) narrowsscopedCommandsto the sub-group and accumulates consumed tokens intoprefix. Theprefixis then correctly used to buildscopedName(e.g."my-cli auth"), but it's also passed to the collect helper functions (collectSkillCommands,buildManifest,buildIndexManifest), which prepend it again to each command name.Fix
Pass an empty
[]prefix to the collect helpers when scoped, sincescopedNamealready carries the group path for display purposes. One-line change plus test updates.Reproduction
Test changes
All 815 tests pass. Updated 6 inline snapshots and 2 assertions in
Cli.test.tsande2e.test.tsthat were asserting the buggy doubled-namespace behavior.