Open
Conversation
- Add Bech32m module with encode/decode using BCH checksum (constant 0x2bc830a3) - Replace double-SHA256 checksum in TempoAddress with bech32m checksum - HRP included in checksum: swapping tempo/tempoz invalidates address - Test vectors match TIP-XXXX spec Amp-Thread-ID: https://ampcode.com/threads/T-019c9c5b-e584-7609-8a5b-ae0acf5fd603 Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Amp-Thread-ID: https://ampcode.com/threads/T-019c9c5b-e584-7609-8a5b-ae0acf5fd603 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch TempoAddress encoding from custom double-SHA256 checksum to standard bech32m (BIP-350) checksum per TIP-XXXX spec.
Details
Bech32mmodule implementing BIP-350 encode/decode with BCH polymod checksum (constant0x2bc830a3)TempoAddress.format/TempoAddress.parsewithBech32m.encode/Bech32m.decodetempo/tempoz) is now included in the checksum computation — swapping prefixes invalidates the addressHashdependency from TempoAddressModules Touched
Bech32mTempoAddress