Qualify ROM library copy workflow - #3
Merged
whatobiplays merged 4 commits intoAug 20, 2026
Conversation
whatobiplays
marked this pull request as ready for review
August 20, 2026 12:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
feature.copy_romsqualification coverage with strict source-bound validation and deterministic fixtures.sync.syncremoves destination-only files before copying source content.Why
Directory-style
syncwas incorrectly preserving destination-only files. The authored contract definessyncas a mirror of its source.Scope
The correction is limited to the shared directory-style copy path. Single-file
sync,merge,replace, and unrelated host/device/app-private/path-list branches retain their existing behavior.Validation
829 passed, 17 ignored), real-execution tests (829 passed, 17 ignored), no-default and real-execution checks, and all-target/all-feature clippy passed.11 passed.47 passed.This remains an automated qualification change; it does not claim physical-device or full end-to-end qualification.
Summary by cubic
Qualifies ROM-library copy, RetroArch first-launch, and XaniteOG install workflows, and corrects directory-style sync to mirror its source. This aligns behavior with the authored contract and adds automated evidence for three production-authored workflows.
Adds automated, production-generated qualification for
feature.copy_roms: verifies planning, review, and deterministicmerge/replace/directory-stylesyncexecution, with a failure-path test; provessyncremoves destination-only files.Extends
app.retroarch.provisionqualification: asserts both first-launch sequences (bootstrap 1500 ms, permissions 5000 ms) and adds a deterministic bootstrap force-stop failure that blocks dependent work without mutating the plan.Adds automated qualification for
app.xaniteog.install: binds a strict contract, validates required.apkinput andpackage_installedskip, executes the unchanged plan through sandbox adapters, skips on repeated run, and truthfully fails on a deterministic install error.Fixes the sandbox fake-device directory-copy path so directory-style
syncremoves the target directory before copy; updates the focused executor regression.Adds
docs/product-contract.jsonanddocs/product/recipe-qualification-xaniteog.md; updates roadmap, RetroArch doc, and context to record these qualifications.Migration
syncpreserving destination-only files, switch tomergeor relocate those files before runningsync. No API changes required.Written for commit bd12b12. Summary will update on new commits.