Skip to content

common: Advanced breakout config#1052

Open
thyal wants to merge 2 commits into
thomas/PAN-2583-breakout-controlsfrom
thomas/PAN-2692-advanced-breakout-config
Open

common: Advanced breakout config#1052
thyal wants to merge 2 commits into
thomas/PAN-2583-breakout-controlsfrom
thomas/PAN-2692-advanced-breakout-config

Conversation

@thyal

@thyal thyal commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Description

Add advanced breakout config. autoMoveToGroup, moveToGroupGracePeriod, autoMoveToMain, moveToMainGracePeriod, breakoutTimerSettings, breakoutTimerDuration, and broadcasting.

Summary:

Related Issue:

Testing

  1. pnpm build && pnpm dev
  2. Open the same room in a different tab
  3. Open the Room Connection with Breakout Groups story and the Room Connection with Breakout Groups Participant (one is with host controls, the other is not)
  4. Play around with the advanced breakout config, verify everything works as expected
  5. Test out broadcasting, both audio/video and chat
  6. Verify that it behaves as expected in the normal room as well as the SDK.

Screenshots/GIFs (if applicable)

Checklist

  • My code follows the project's coding standards.
  • Prefixed the PR title and commit messages with the service or package name
  • I have written unit tests (if applicable).
  • I have updated the documentation (if applicable).
  • By submitting this pull request, I confirm that my contribution is made
    under the terms of the MIT license.

Additional Information

@thyal
thyal requested a review from a team June 30, 2026 12:49
@changeset-bot

changeset-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0eab7d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@whereby.com/browser-sdk Minor
@whereby.com/core Minor
@whereby.com/assistant-sdk Patch
@whereby.com/react-native-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thyal
thyal force-pushed the thomas/PAN-2692-advanced-breakout-config branch from 81b3438 to 0eab7d9 Compare July 2, 2026 13:14

@sarahrose-ferris sarahrose-ferris left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this out and it works really well 👏 just one comment for now, but I also wanted to mention that I see this error a lot when joining breakout groups:

Image

I haven't debugged this yet (let me know if you want me to) but maybe this is something we should take a look at? 🙏

dispatch(setBreakoutGroupAssigned({ breakoutGroupAssigned }));

// Notify the local participant when they've been assigned to a group. Unassignment
// (empty group) is intentionally not surfaced as a notification.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we check if breakout group is active here before notifying? If I had been assigned a breakout group in a previous session but the session is no longer active and I rejoin the room, I will see the 'you've been assigned' notification

@sarahrose-ferris

sarahrose-ferris commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Actually I tested this out a little bit more, and I noticed that when:

  1. participant a is in a normal room, b and c are in the sdk
  2. participant a joins a breakout group, b and c stay in the main room
  3. participant a goes back to the main group
  4. participant a loses connection to b and c and vice versa (b + c can still see each other but not a)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants