Skip to content

core: release camera and microphone when the local client is kicked#1062

Merged
thyal merged 1 commit into
mainfrom
thomas/PAN-2716-active-mic-after-meeting-end
Jul 22, 2026
Merged

core: release camera and microphone when the local client is kicked#1062
thyal merged 1 commit into
mainfrom
thomas/PAN-2716-active-mic-after-meeting-end

Conversation

@thyal

@thyal thyal commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Description

Fixes #1055.

We're missing the clean up (doAppStop), when a client is kicked. This also applies to when the host ends meeting for all (as that is technically the host kicking everyone with the reason end-meeting.

Summary:

Related Issue:

Testing

  1. pnpm build && pnpm dev
  2. Go to the Room Connection with Host Controls story, and open it in 2 tabs
  3. Click the end meeting button
  4. Verify that the mic/cam is released from both tabs.

Screenshots/GIFs (if applicable)

Checklist

  • My code follows the project's coding standards.
  • Prefixed the PR title and commit messages with the service or package name
  • I have written unit tests (if applicable).
  • I have updated the documentation (if applicable).
  • By submitting this pull request, I confirm that my contribution is made
    under the terms of the MIT license.

Additional Information

@changeset-bot

changeset-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e54cab7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@whereby.com/core Patch
@whereby.com/assistant-sdk Patch
@whereby.com/browser-sdk Patch
@whereby.com/react-native-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thyal
thyal requested a review from a team July 22, 2026 09:16

@sarahrose-ferris sarahrose-ferris left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well 👏

@thyal
thyal merged commit 7077da3 into main Jul 22, 2026
3 checks passed
@thyal
thyal deleted the thomas/PAN-2716-active-mic-after-meeting-end branch July 22, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microphone and camera remain active for participants after the host ends the meeting

2 participants