Skip to content

common: Add waiting room message for on hold and rejected knocks#1065

Open
thyal wants to merge 1 commit into
mainfrom
thomas/PAN-2732-waiting-room-message
Open

common: Add waiting room message for on hold and rejected knocks#1065
thyal wants to merge 1 commit into
mainfrom
thomas/PAN-2732-waiting-room-message

Conversation

@thyal

@thyal thyal commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Description

Add support for providing a waiting room message for on hold/rejected knocks. This also adds on-hold as a knock status and a function to put knockers on hold (currently we only have accept and reject in the SDK).

Summary:

Related Issue:

Testing

  1. pnpm build && pnpm dev
  2. Open the Room Connection With Host Controls story with a locked room
  3. Open the same room in an incognito tab (without the host key)
  4. Knock from the incognito tab
  5. Put the knocker on hold with a message
  6. Verify the message displays on the knocker's side
  7. Do the same with reject.

Screenshots/GIFs (if applicable)

Checklist

  • My code follows the project's coding standards.
  • Prefixed the PR title and commit messages with the service or package name
  • I have written unit tests (if applicable).
  • I have updated the documentation (if applicable).
  • By submitting this pull request, I confirm that my contribution is made
    under the terms of the MIT license.

Additional Information

@changeset-bot

changeset-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c1191e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@whereby.com/browser-sdk Minor
@whereby.com/media Minor
@whereby.com/core Minor
@whereby.com/audio-denoiser Patch
@whereby.com/assistant-sdk Patch
@whereby.com/react-native-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thyal
thyal requested a review from a team July 24, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant