fix: metadata validator requires national number without leading zero#88
Merged
rubdos merged 2 commits intowhisperfish:mainfrom Oct 9, 2025
Merged
Conversation
rubdos
approved these changes
Oct 9, 2025
Member
rubdos
left a comment
rubdos
left a comment
There was a problem hiding this comment.
Yep, makes a lot of sense.
This closes most of the 0-prefix issues? Or is that still a separate case?
Collaborator
Author
|
Sorry, I was confused. I think it closes most of the 0-prefix issues. However, the formatter is still not correct, which is a separate issue. |
Collaborator
Author
|
I checked, and this PR does not fix the 0-prefix issues. Only the |
This was referenced Oct 9, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validator for the number type first does a check with the following regex
"[1-9]\\d{8}". We should pass the national (significant) number to the validator instead of the number with the leading zero.