refactor: CorruptionManager → DecryptReveal (narrow to decryption-only)#23
Merged
Conversation
…ion-only Disambiguates the two corruption patterns: - TypingAnimation = streaming/typed reveal (string grows over time) - DecryptReveal = fixed-length decryption (string is final length, scrambled with chars from charset, progressively resolves) The .flicker() and .hybrid() methods were a port artifact from celeste-tts-bot's unified lifecycle helper. They conceptually overlap with TypingAnimation's streaming-buffer pattern, causing user/LLM confusion. Dropped in favor of crisp single-purpose classes. API changes (breaking, pre-1.0): - src/core/corruption-manager.js → src/core/decrypt-reveal.js - Class CorruptionManager → DecryptReveal - Methods .decode/.start/.stop/.destroy retained - Methods .flicker/.hybrid removed - Standalone exports decodeText retained - Standalone exports phraseFlicker/hybridDecode removed - package.json export ./corruption-manager → ./decrypt-reveal Updated: README, CHANGELOG, COMPONENTS_REFERENCE, COMPONENT_LIBRARY, COMPONENT_MAPPING, NPM_PACKAGE, WEB_IMPLEMENTATION, all demo HTML pages (index, examples/index, showcase, showcase-complete, crt-effects, particles-background, animation-blocks/index, components/*), and renamed example examples/advanced/corruption-manager.html → decrypt-reveal.html. Tests: 155 pass, 0 fail (dropped 3 flicker/hybrid tests, count was 158). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disambiguates two corruption patterns that were conflated in plan #2's port:
The `.flicker()` and `.hybrid()` methods on CorruptionManager were a port artifact from celeste-tts-bot's unified lifecycle helper. They conceptually overlap with TypingAnimation's streaming-buffer pattern, causing user/LLM confusion in docs and example pages.
API changes (breaking, pre-1.0)
Files updated
README, CHANGELOG, COMPONENTS_REFERENCE, COMPONENT_LIBRARY, COMPONENT_MAPPING, NPM_PACKAGE, WEB_IMPLEMENTATION, all demo HTML pages (index/examples/showcase pair, plus crt-effects, particles-background, animation-blocks/index, all components/* pages with nav submenus).
Test plan
🤖 Generated with Claude Code