Development environment setup#4
Merged
Merged
Conversation
Co-authored-by: gaoyang2024 <gaoyang2024@users.noreply.github.com>
P0: FocusFinder 返回 null 时焦点卡死 — 增加 handleFocusBoundary 回退逻辑 P0: 主菜单按左键无法进入已展开子菜单 — 增加 DPAD_LEFT 显式处理与 focusSubmenuFirstItem P1: 频道列表自动隐藏后焦点丢失 — hideChannelListIdleRunnable 和 hideOverlay 中恢复焦点 P1: 频道列表按返回键直接弹退出对话框 — BACK 键先关闭频道列表 P2: 焦点路过主菜单项导致子菜单频繁重建 — onMainMenuItemFocused 增加 150ms 防抖 P3: ACTION_UP 事件泄漏 — 增加 onKeyUp 拦截 + dispatchDrawerKey 同时转发 ACTION_UP Co-authored-by: gaoyang2024 <gaoyang2024@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6b4c9b2. Configure here.
Co-authored-by: 白一梓 <yunnysunny@gmail.com>
Co-authored-by: 白一梓 <yunnysunny@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleFocusBoundaryfallback fromSettingsCollapsibleFragmentbecause the same menu/submenu focus transitions return beforeFocusFinderruns.focused != nullchecks after the panel descendant guard guarantees a focused view within the settings panel.Testing
./gradlew testDebugUnitTest --no-daemon— passed./gradlew assembleDebug --no-daemon— passed