Skip to content

fix: seed users and refresh stats for all courses with threads #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahmed-arb merged 1 commit into from
Jul 1, 2026
Merged

fix: seed users and refresh stats for all courses with threads #657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions lms/djangoapps/discussion/management/commands/reconnect_legacy_discussion_threads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,14 @@
or a commentable whose XBlock no longer exists) is registered as a course-level
topic so the threads remain reachable, and is reported rather than clobbered.

It then recomputes per-course user stats so the "Learners" tab populates. It performs
only Django-model writes (``DiscussionsConfiguration`` / ``DiscussionTopicLink``) plus
the stats recompute -- no modulestore/content writes and no forum-store writes -- so
it is reversible.
For **every** course that has threads -- whether or not any topics needed reconnecting
-- it also seeds ``ForumUser`` records for enrolled users and recomputes per-course user
stats, so the "Learners" tab populates. (The Mongo->MySQL migration brings threads but
not ``ForumUser`` records, and the stats read does ``ForumUser.objects.get()`` per
stat-bearing user, so a missing record otherwise makes the endpoint fail.) It performs
only Django-model writes (``DiscussionsConfiguration`` / ``DiscussionTopicLink`` /
``ForumUser``) plus the stats recompute -- no modulestore/content writes and no
forum thread/comment writes -- so it is reversible.

Invoke with (dry-run by default)::

Expand Down Expand Up @@ -172,8 +176,6 @@ def _process_course(self, course_key):
links = list(DiscussionTopicLink.objects.filter(context_key=course_key, provider_id=PROVIDER))
linked_external_ids = {link.external_id for link in links}
orphans = active - linked_external_ids
if not orphans:
return {"course": str(course_key), "status": "healthy", "threads": len(active)}

xmap = self._build_xblock_map(course_key)
links_by_unit = {link.usage_key: link for link in links if link.usage_key}
Expand Down Expand Up @@ -217,7 +219,8 @@ def _process_course(self, course_key):

if not self.apply:
self.stdout.write(" (dry-run: no changes written)")
return {"course": str(course_key), "status": "would-fix", "actions": len(plan)}
status = "would-fix" if plan else "would-refresh-stats"
return {"course": str(course_key), "status": status, "actions": len(plan)}

if need_graded and not config.enable_graded_units:
config.enable_graded_units = True
Expand Down Expand Up @@ -251,7 +254,8 @@ def _process_course(self, course_key):
seeded = self._seed_forum_users(course_key)
update_course_users_stats(course_key)
self.stdout.write(f" -> applied; seeded {seeded} forum users; user stats recomputed")
return {"course": str(course_key), "status": "fixed", "actions": len(plan), "seeded_users": seeded}
status = "fixed" if plan else "stats-refreshed"
return {"course": str(course_key), "status": status, "actions": len(plan), "seeded_users": seeded}

def _seed_forum_users(self, course_key):
"""
Expand Down
Loading