One Name Trees: Include those with LastNameOther#408
Merged
Conversation
Standardize surname comparisons and present 'aka' last names in the UI. Added CSS for .akaLastNames styling. JS changes: introduce wtPlusMatches (Set) and populate it from API results; add getStandardizedOtherLastNames() and getAkaLastNamesDisplay() to handle comma-separated LastNameOther values, avoid duplicates, and omit a person's own surnames. Convert many surname comparisons to use standardized forms so matching is case/whitespace-insensitive and correctly checks multiple other-last-name entries. Include wtPlusMatches as an alternate match in filtering logic, and adjust location/century checks accordingly. Update person and spouse list rendering to append aka display when appropriate. Remove debug shouldLog/shouldLogIds code and related no-op logging. Also standardize watchlist parsing to use the new standardized comparisons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize surname comparisons and present 'aka' last names in the UI. Added CSS for .akaLastNames styling. JS changes: introduce wtPlusMatches (Set) and populate it from API results; add getStandardizedOtherLastNames() and getAkaLastNamesDisplay() to handle comma-separated LastNameOther values, avoid duplicates, and omit a person's own surnames. Convert many surname comparisons to use standardized forms so matching is case/whitespace-insensitive and correctly checks multiple other-last-name entries. Include wtPlusMatches as an alternate match in filtering logic, and adjust location/century checks accordingly. Update person and spouse list rendering to append aka display when appropriate. Remove debug shouldLog/shouldLogIds code and related no-op logging. Also standardize watchlist parsing to use the new standardized comparisons.