fixes #121 destruct sigma types#129
Open
stchang wants to merge 2 commits intowilbowma:mainfrom
Open
Conversation
Collaborator
Author
|
fixes #121 |
Owner
|
I could see an argument for yes. It would increase performance, and we ought to only be constructing well-typed terms. However, it might also be useful for debugging tactics. |
Collaborator
Author
|
True. I do see that several tactics raise their own exceptions when given an ill-typed expression, so it may not be completely straightforward to completely disable type checking. For now, I'll just do it when appropriate for individual tactics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a temporary fix but it got me thinking, should we disable type checking completely while running tactics? The final term will be type checked anyways right?