fix: show ai once backend initialization status - #1415
mikemikimike wants to merge 3 commits into
Conversation
|
Thank you for your contribution to caro! 🎉 Before we can merge your pull request, we need you to sign our Contributor License Agreement (CLA). How to SignPlease read our CLA here: CLA.md Once you've read and agree to the terms, simply comment on this PR with: Alternative: Developer Certificate of Origin (DCO)If you prefer, you can use DCO instead by signing off your commits with: git commit -s -m "Your commit message"See DCO.txt for details. Note: You only need to sign once. Your signature will cover all future contributions to caro. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Welcome to caro! 🎉Thank you for your first pull request, @mikemikimike! We're thrilled to have you as a contributor. Review Process:
Helpful Resources: Tips for a smooth review:
We appreciate your contribution! ❤️ |
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
@mikemikimike is attempting to deploy a commit to the KADOSH DEV Team on Vercel. A member of the Team first needs to authorize it. |
|
recheck |
|
I rechecked this PR for issue #1408. The remaining red check is cla-check, and I have already signed the CLA in the PR comments. This is a repository contribution gate, not a code failure from the change. Could a maintainer please refresh or rerun the CLA check and review/approve the PR? |
Summary
Closes #1408.
caro ai --oncenow writes an initialization status line to stderr before backend construction, so first-run model initialization is no longer silent. stdout remains reserved for the generated command text.Implementation
CliApp::with_overrides(...).await.Testing
cargo test --bin caro ai_once_initialization_message_is_stable— passed (1 passed, 22 filtered out).unreachable_codewarnings insrc/models/mod.rsandsrc/platform/mod.rs.git diff --check— passed.Not run: full
cargo test,cargo clippy -- -D warnings, and full formatting check. The full test command previously attempted to update crates.io and stalled in the network environment; offline mode lacked the cachedrav1ecrate. The repository-wide formatting check reports existing line-ending discrepancies across many files.Summary by cubic
Make
caro ai --oncereport backend initialization so first runs aren’t silent. It now writes "Initializing backend…" to stderr right before backend construction; stdout remains command text only.Refactors
Migration
Written for commit d9d417a. Summary will update on new commits.