Add dynamical as a priority/source - #88
Open
williamhobbs wants to merge 17 commits into
Open
williamhobbs wants to merge 17 commits into
williamhobbs wants to merge 17 commits into
Conversation
Owner
Author
|
For filters/checks/warnings on input parameter combinations, combinations that don't work:
|
Owner
Author
|
[edit: this was fixed with 2c3adf1] This bit of code is not working for non-dynamical sources: Lines 1746 to 1764 in 7613eba get_fcast_dataframe is getting temperatures for all members, not just the control. An example of this: member_cust = 0
resource_type = 'solar'
latitude = [32, 30]
longitude = [-89, -90]
init_date = pd.Timestamp('2026-09-10 00:00:00')
fxx_range = range(9, 16, 3)
model = 'ifs_ens'
search_str_cust = ':2t'
priority = 'azure'
product = 'enfo'
fast=True
attempts=2
df_rem = get_fcast_dataframe(
latitude, longitude, init_date, fxx_range, model,
search_str_cust, priority, product,
fast, attempts, resource_type,
member_cust)
df_remreturns a dataframe with 300 rows, but it should be 6. To get just the control from IFS ens, options are:
I think the solution is to use the |
Catch add_dynamical up with changes to main
Owner
Author
|
Informal tests included:
resource = get_solar_forecast_ensemble(
latitude=[32, 30], longitude=[-89, 90],
init_date='2026-09-10', run_length=6,
lead_time_to_start=12, model='ifs_ens',
attempts=2, priority='azure')
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #68, #2, #56 (after it was re-opened), #87, and #89.
To-do list:
consider condensing functions (e.g., merge get_solar_forecast and get_solar_forecast_fast into one withI decided not to do this, at least for now.use_fastherbieas an input parameter, maybe also merge the ensemble function as well...)