feat: ui material design overhaul (formerly bottom sheet material) #237

williscool · 2026-01-22T03:37:37Z

refs #15

Note

Modernizes UI with Material components and refactors time selection flows.

Replace AlertDialog, platform DatePicker/TimePicker, and Toast with MaterialAlertDialogBuilder, MaterialDatePicker, MaterialTimePicker, and Snackbar across activities/fragments (edit/view/snooze, main, settings, dismissed events, pre-action)
Update layouts to Material widgets: MaterialToolbar, MaterialDivider, Material checkboxes/radio buttons/cards, exposed dropdown menus; remove legacy date/time picker layouts
Refactor reminder/time interval pickers to use AutoCompleteTextView (exposed dropdown) instead of Spinner, updating logic in TimeIntervalPickerController and ReminderPatternPreferenceX
Improve date/time handling (UTC-to-local conversions, restore listeners) and add visibility/UX tweaks (e.g., hide empty time text)
Adjust tests to look for R.string.choose_date; mark one flaky calendar monitor test as @Ignore
Minor type cleanups in adapters (View/ViewGroup vs RelativeLayout) and add calendar_color_indicator drawable

^{Written by Cursor Bugbot for commit 4b80163. This will update automatically on new commits. Configure here.}

github-actions · 2026-01-22T03:50:10Z

Build artifacts for PR #237 (commit 9d50996) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

github-actions · 2026-01-22T04:01:40Z

Code Coverage Report

Overall Project	34.75% `-2.16%`	🍏
Files changed	14.62%	❌

Module	Coverage
app	42.4% `-2.09%`	❌
x8664Debug	27.26% `-2.24%`	❌

Files

Module	File	Coverage
app	DismissedEventsActivity.kt	74.93%	🍏
	DismissedEventsFragment.kt	70.01%	🍏
	MainActivityLegacy.kt	55.93% `-1.11%`	❌
	ActiveEventsFragment.kt	55.22% `-0.08%`	🍏
	MainActivityBase.kt	53.32% `-2.27%`	❌
	ViewEventActivityNoRecents.kt	52.44% `-12.86%`	❌
	SnoozeAllActivity.kt	51.72% `-15.94%`	❌
	MainActivityModern.kt	50.41% `-0.83%`	❌
	DismissedEventListAdapter.kt	50.08% `-0.88%`	🍏
	EventListAdapter.kt	41.21% `-0.74%`	🍏
	TimeIntervalPickerController.kt	38.87% `-9.03%`	🍏
	SnoozePresetPreferenceX.kt	27.07% `-1.27%`	❌
	MiscSettingsFragmentX.kt	11.06% `-3.8%`	❌
	NavigationSettingsFragmentX.kt	0% `-3.92%`	❌
	CalendarsActivity.kt	0% `-0.53%`	❌
	ListPreference.kt	0% `-5.08%`	❌
	ReminderPatternPreferenceX.kt	0% `-15.67%`	❌
	ReportABugActivity.kt	0% `-5.52%`	❌
	EditEventActivity.kt	0% `-17.63%`	❌
	PreActionActivity.kt	0% `-2.84%`	❌
x8664Debug	TimeIntervalPickerController.kt	78.99% `-5.04%`	🍏
	CalendarsActivity.kt	69.44% `-0.53%`	❌
	DismissedEventsFragment.kt	57.83% `-0.54%`	❌
	PreActionActivity.kt	54.8% `-2.84%`	❌
	MainActivityLegacy.kt	52.12% `-1.11%`	❌
	MainActivityModern.kt	50.09% `-0.83%`	❌
	ActiveEventsFragment.kt	49.92% `-0.08%`	🍏
	EventListAdapter.kt	49.06% `-0.74%`	🍏
	DismissedEventsActivity.kt	48.99% `-1.44%`	❌
	MainActivityBase.kt	48.49% `-1.51%`	❌
	ViewEventActivityNoRecents.kt	44.95% `-16.51%`	❌
	DismissedEventListAdapter.kt	44.23% `-0.88%`	🍏
	SnoozeAllActivity.kt	34.08% `-20.48%`	❌
	SnoozePresetPreferenceX.kt	27.07% `-1.27%`	❌
	ReminderPatternPreferenceX.kt	13.64% `-15.67%`	❌
	MiscSettingsFragmentX.kt	11.06% `-3.8%`	❌
	NavigationSettingsFragmentX.kt	0% `-3.92%`	❌
	ListPreference.kt	0% `-5.08%`	❌
	ReportABugActivity.kt	0% `-5.52%`	❌
	EditEventActivity.kt	0% `-17.63%`	❌

github-actions · 2026-01-22T04:01:43Z

📊 Code Coverage Summary

Coverage Type	Coverage
Overall	34.89
Changed Files	100

View detailed coverage report

github-actions · 2026-01-22T04:30:03Z

Build artifacts for PR #237 (commit 7ac3324) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

github-actions · 2026-01-22T04:41:48Z

📊 Code Coverage Summary

Coverage Type	Coverage
Overall	34.91
Changed Files	100

View detailed coverage report

github-actions · 2026-01-22T04:49:42Z

Build artifacts for PR #237 (commit 6385243) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

github-actions · 2026-01-22T04:55:44Z

📊 Code Coverage Summary

Coverage Type	Coverage
Overall	27.35
Changed Files	34.15

View detailed coverage report

github-actions · 2026-01-22T05:43:42Z

Build artifacts for PR #237 (commit 7acc307) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

github-actions · 2026-01-22T05:50:30Z

📊 Code Coverage Summary

Coverage Type	Coverage
Overall	null
Changed Files	100

View detailed coverage report

github-actions · 2026-01-22T06:17:34Z

Build artifacts for PR #237 (commit a395f84) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

android/app/src/main/java/com/github/quarck/calnotify/ui/EditEventActivity.kt

github-actions · 2026-01-25T19:12:32Z

Build artifacts for PR #237 (commit 02e5ecf) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

github-actions · 2026-01-25T19:25:57Z

📊 Code Coverage Summary

Coverage Type	Coverage
Overall	null
Changed Files	100

View detailed coverage report

github-actions · 2026-01-25T19:36:10Z

Build artifacts for PR #237 (commit 380f4a6) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

github-actions · 2026-01-25T19:42:36Z

📊 Code Coverage Summary

Coverage Type	Coverage
Overall	null
Changed Files	100

View detailed coverage report

github-actions · 2026-01-25T19:59:57Z

📊 Code Coverage Summary

Coverage Type	Coverage
Overall	null
Changed Files	100

View detailed coverage report

github-actions · 2026-01-25T20:13:34Z

📊 Code Coverage Summary

Coverage Type	Coverage
Overall	null
Changed Files	100

View detailed coverage report

github-actions · 2026-01-25T20:20:38Z

📊 Code Coverage Summary

Coverage Type	Coverage
Overall	null
Changed Files	100

View detailed coverage report

github-actions · 2026-01-25T20:49:00Z

Build artifacts for PR #237 (commit d99dd33) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

github-actions · 2026-01-25T20:59:34Z

📊 Code Coverage Summary

Coverage Type	Coverage
Overall	34.78
Changed Files	34.7

View detailed coverage report

williscool · 2026-01-25T21:47:59Z

android/app/src/main/java/com/github/quarck/calnotify/ui/SnoozeAllActivity.kt

+            .show()
+    }
+
+    private fun localMidnightMillisFromUtcDateSelection(dateSelectionUtcMillis: Long): Long {


This should be in a utility function class somewhere and tested separately

williscool · 2026-01-25T21:58:40Z

android/app/src/main/java/com/github/quarck/calnotify/ui/EditEventActivity.kt

+        picker.show(supportFragmentManager, "timeFromPicker")
    }

    @Suppress("UNUSED_PARAMETER")


Can We get rid of this suppression?

williscool · 2026-01-25T22:01:08Z

android/app/src/test/java/com/github/quarck/calnotify/ui/TimeIntervalPickerControllerTest.kt

@@ -2,8 +2,8 @@ package com.github.quarck.calnotify.ui

 import android.view.LayoutInflater


Given that we've changed the UI here will need to pay close attention to how this test changes things and make sure it's testing the right stuff

williscool · 2026-01-25T22:20:19Z

android/app/src/main/java/com/github/quarck/calnotify/prefs/ReminderPatternPreferenceX.kt

            layoutCustomPattern = view.findOrThrow(R.id.layout_reminder_interval_custom)

-            timeUnitsSpinners.adapter = ArrayAdapter(
+            timeUnitsArray = view.context.resources.getStringArray(R.array.time_units_plurals_with_seconds)


What's this?

williscool · 2026-01-25T22:21:26Z

android/app/src/main/java/com/github/quarck/calnotify/prefs/ReminderPatternPreferenceX.kt

                    if (simpleIntervalMillis == 0L) {
                        simpleIntervalMillis = 60 * 1000L
-                        Toast.makeText(context, R.string.invalid_reminder_interval, Toast.LENGTH_LONG).show()
+                        Toast.makeText(requireContext(), R.string.invalid_reminder_interval, Toast.LENGTH_LONG).show()


We should have some guidelines in the docs on where to and not to use toasts and snackbars

williscool · 2026-01-25T22:22:00Z

android/app/src/main/java/com/github/quarck/calnotify/ui/DismissedEventListAdapter.kt

        var entry: DismissedEventAlertRecord? = null

-        var eventHolder: RelativeLayout?
+        var eventHolder: View?


Just curious why this change?

williscool · 2026-01-25T22:23:29Z

android/app/src/main/java/com/github/quarck/calnotify/ui/EventListAdapter.kt

+            undoLayout = itemView.find<ViewGroup?>(R.id.event_card_undo_layout)

-            compactViewContentLayout = itemView.find<RelativeLayout?>(R.id.compact_view_content_layout)
+            compactViewContentLayout = itemView.find<ViewGroup?>(R.id.compact_view_content_layout)


williscool · 2026-01-25T22:25:18Z

android/app/src/main/java/com/github/quarck/calnotify/ui/TimeIntervalPickerController.kt

@@ -20,11 +20,10 @@
 package com.github.quarck.calnotify.ui


Got to think deeply about this. One of the most important parts of the app need to make sure it does the right things

williscool · 2026-01-25T22:26:59Z

android/app/src/main/java/com/github/quarck/calnotify/ui/ViewEventActivityNoRecents.kt

@@ -20,7 +20,11 @@

 package com.github.quarck.calnotify.ui


Need a summary of the changes here. What are they? Why are we making them?

williscool · 2026-01-25T22:28:21Z

android/app/src/main/java/com/github/quarck/calnotify/ui/SnoozeAllActivity.kt


 import android.annotation.SuppressLint
-import android.app.AlertDialog
+import com.google.android.material.dialog.MaterialAlertDialogBuilder


Need a summary of the changes here and why we are been making them. Also, it seems like there's a whole lot of overlap with what we are doing in the view event activity. Also, I wonder if we could refactor that to be shared somehow?

github-actions · 2026-01-26T01:06:20Z

Build artifacts for PR #237 (commit 4b80163) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

cursor · 2026-01-26T01:06:43Z

android/app/src/main/java/com/github/quarck/calnotify/prefs/MiscSettingsFragmentX.kt


    private fun showToast(messageResId: Int) {
-        Toast.makeText(requireContext(), messageResId, Toast.LENGTH_LONG).show()
+        view?.let { Snackbar.make(it, messageResId, Snackbar.LENGTH_LONG).show() }


Snackbar silently fails when fragment view unavailable

Low Severity

The showToast function was changed from using Toast.makeText(requireContext(), ...) to view?.let { Snackbar.make(it, ...) }. If view is null (e.g., fragment view destroyed during activity recreation while file picker is open), the Snackbar silently fails to show and users receive no feedback about export/import success or failure. The original Toast implementation would show messages regardless of fragment view state.

github-actions · 2026-01-26T01:13:18Z

📊 Code Coverage Summary

Coverage Type	Coverage
Overall	27.26
Changed Files	36.26

View detailed coverage report

github-actions · 2026-01-26T01:20:34Z

📊 Code Coverage Summary

Coverage Type	Coverage
Overall	27.26
Changed Files	36.26

View detailed coverage report

github-actions · 2026-01-26T01:44:48Z

📊 Code Coverage Summary

Coverage Type	Coverage
Overall	34.75
Changed Files	34.64

View detailed coverage report

williscool added 2 commits January 22, 2026 04:14

fix: bottom sheet styles material

97d5dad

docs: plant for full material components migration

7ac3324

williscool force-pushed the fix/bottom_sheet_styles_material_update branch from 9d50996 to 7ac3324 Compare January 22, 2026 04:18

williscool changed the title ~~fix: bottom sheet styles material~~ feat: ui material design overhaul (formerly bottom sheet material) Jan 22, 2026

This comment was marked as outdated.

Sign in to view

docs: phases

096374d

williscool added 2 commits January 22, 2026 04:32

docs: phase 3

e46e4bb

feat: phase 1

6385243

This comment was marked as outdated.

Sign in to view

docs: cleanup

6464a82

williscool added 5 commits January 22, 2026 04:58

docs: plan update

abe1b90

feat: draw most of the rest of the owl lol

47bf1c2

docs: deprecated_features

315156a

feat: everything but time pickers

7acc307

docs: more legacy code

db25023

This comment was marked as outdated.

Sign in to view

williscool added 3 commits January 22, 2026 05:56

feat: migrate old custom pickers

9afeb5d

feat: last bit of trivial stuff

a395f84

fix: simple event list update

7a9b9e6

This comment was marked as outdated.

Sign in to view

cursor bot reviewed Jan 25, 2026

View reviewed changes

android/app/src/main/java/com/github/quarck/calnotify/ui/EditEventActivity.kt Show resolved Hide resolved

fix: build

02e5ecf

fix: TimeIntervalPickerController test

380f4a6

williscool added 2 commits January 25, 2026 20:26

test: fix

e182ba6

test: ignore flaky deprecated test for now

d99dd33

williscool commented Jan 25, 2026

View reviewed changes

fix: round out toolback updates

4b80163

cursor bot reviewed Jan 26, 2026

View reviewed changes

		@@ -2,8 +2,8 @@ package com.github.quarck.calnotify.ui

		import android.view.LayoutInflater

feat: ui material design overhaul (formerly bottom sheet material) #237

Are you sure you want to change the base?

feat: ui material design overhaul (formerly bottom sheet material) #237

Uh oh!

Conversation

williscool commented Jan 22, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Report

Uh oh!

github-actions bot commented Jan 22, 2026

📊 Code Coverage Summary

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 22, 2026

📊 Code Coverage Summary

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 22, 2026

📊 Code Coverage Summary

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 22, 2026

📊 Code Coverage Summary

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

Uh oh!

github-actions bot commented Jan 25, 2026

Uh oh!

github-actions bot commented Jan 25, 2026

📊 Code Coverage Summary

Uh oh!

github-actions bot commented Jan 25, 2026

Uh oh!

github-actions bot commented Jan 25, 2026

📊 Code Coverage Summary

Uh oh!

github-actions bot commented Jan 25, 2026

📊 Code Coverage Summary

Uh oh!

github-actions bot commented Jan 25, 2026

📊 Code Coverage Summary

Uh oh!

github-actions bot commented Jan 25, 2026

📊 Code Coverage Summary

Uh oh!

github-actions bot commented Jan 25, 2026

Uh oh!

github-actions bot commented Jan 25, 2026

📊 Code Coverage Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

williscool Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

williscool commented Jan 22, 2026 •

edited by cursor bot

Loading

github-actions bot commented Jan 22, 2026 •

edited

Loading

williscool Jan 25, 2026 •

edited

Loading

williscool Jan 25, 2026 •

edited

Loading