Cope with Ansible >= 2.4 inventory changes - #85
Open
nphilipp wants to merge 4 commits into
Open
Conversation
Author
|
NB: I'm not really familiar with Ansible innards myself, so please pay special attention to the actual functional changes in the "Cope with Ansible >= 2.4 inventory changes." commit when reviewing. Thanks. |
nphilipp
force-pushed
the
master--ansible-2.4-inventory
branch
from
December 23, 2019 14:48
267502c to
249c0fb
Compare
If pep8-naming is installed, flake8 will flag importing a camel-cased module on Python 2 as the (better) name of the equivalent module in Python. Signed-off-by: Nils Philippsen <nils@redhat.com>
Signed-off-by: Nils Philippsen <nils@redhat.com>
Signed-off-by: Nils Philippsen <nils@redhat.com>
Signed-off-by: Nils Philippsen <nils@redhat.com>
nphilipp
force-pushed
the
master--ansible-2.4-inventory
branch
from
June 9, 2020 13:38
249c0fb to
6bbe8b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to deal with changes in Ansible 2.4 which removed
ansible.inventory.Inventory, apparently to be replaced byansible.inventory.manager.InventoryManager.Here's how it behaved without the changes in this PR:
This PR also lets ansible-review cope with exceptions caught that don't have a
messageattribute.