Temporarily deprecate workflow support (#23) - #26
Open
willwebster5 wants to merge 8 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…od tests (#23) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Temporarily deprecates talonctl workflow support so the tool stops crashing on workflows, while preserving the provider code for a future tested rewrite. Addresses the immediate breakage in #23.
Why
The workflow provider was non-functional (verified against FalconPy
Workflowsv1.6.1):apply_deletecalleddelete_definition(...)— no delete method exists on theWorkflowsclass; the CrowdStrike Workflows API does not expose workflow-definition deletion.requires_replacement()forced REPLACE (delete + recreate) for every change andapply_update()hard-raised — so with no delete, no workflow change was deployable;applycrashed mid-wave._fetch_all_remote_workflowscalledget_definitions(...)— also non-existent →sync/driftraisedAttributeError. (search_definitionsalready returns full models, so that batch loop was never needed.)update_definitionexists but 500s on a naive compiled-model round-trip; the correct payload shape is unknown and can't be validated without live-tenant access.A partial-but-crashing provider is worse than an honestly-unavailable one, hence temporary deprecation rather than a rushed, untestable fix.
What changed
template_discovery.py):"workflow"moved to a newDEPRECATED_RESOURCE_TYPES. Workflow templates are still scanned, emit a clear deprecation warning, and are excluded from results — so no"workflow"key reachesvalidate/plan/apply/sync/drift.provider_adapter.py): workflow provider unregistered."workflow"removed fromFETCHABLE_TYPES.resources/workflows/.Behavior after this change
A project that still contains workflow templates gets a one-time warning and the templates are ignored; all other resource types proceed normally. No command crashes — even with an explicit
--resources=workflow(downstream consumers all use.get()/ iterate discovered results).Testing
pytest tests/— 799 passed;ruff format --check .andruff check .clean.get_definitions,delete_definition) — they passed only viaMockauto-attributes, codifying the bug.Not in scope
A working update path (needs live-tenant testing of the
update_definition500 and possibly a CrowdStrike support ticket) and disable-as-destroy semantics viaworkflow_definition_action— these belong to the future un-deprecation work.🤖 Generated with Claude Code