Fix DOM canvas resize synchronization - #355
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix DOM window resize handling so canvas-backed windows stay synchronized with their rendered size and emit resize events from scheduled window state updates instead of DOM resize events on the canvas.
Solution
setUpWindowEventslistener becauseresizeevents are not a reliable canvas event source for DOM canvas size changes.syncWindowSizeduring window registration to initialize both the canvas backing size and styled size from theWindowcomponent.resizeWindowsystem to check registered canvases and update theirWindowcomponent when the DOM size changes.WindowResizeto receive explicitwidthandheightvalues instead of reading them from aUIEvent.Windowresource consistently.Showcase
Before
Resize events depended on manually dispatched canvas events, and
WindowResizeextracted size from the event target.After
Resize state is detected by the DOM window system and emitted with explicit dimensions.
Migration guide
No breaking changes
Checklist