[codex] Support pnpm 11 build approvals#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.json#pnpm.onlyBuiltDependenciessetting topnpm-workspace.yaml#allowBuilds.Root cause
During comprehensive local testing, pnpm 11 refused to continue because it no longer reads
pnpm.onlyBuiltDependenciesfrompackage.json. It auto-added placeholderallowBuildsentries and failed withERR_PNPM_IGNORED_BUILDS. The official pnpm 11 guidance is to useallowBuildsinpnpm-workspace.yamlinstead.Validation
node --test tests/*.test.mjsbefore the fix: 192 passedpnpm testafter the fix: 193 passedpnpm typecheckpnpm buildpnpm check:release-qualitypnpm website:buildpnpm rc:checkpnpm rc:artifactsnode scripts/release_artifact_smoke.mjsnode scripts/check_no_lite_release_assets.mjsnode scripts/check_nvidia_release_assets.mjsnode scripts/check_release_notes_i18n.mjsnode scripts/package_artifact_smoke.mjs --mode=devnode scripts/smoke_windows_packaged_app.mjs --mode=full --require-katago --exe=.tmp/user-download-v0.4.17/standard-portable/GoAgent.exenode scripts/smoke_windows_packaged_app.mjs --mode=nvidia --require-katago --exe=.tmp/user-download-v0.4.17/nvidia-portable/GoAgent.exegit diff --checkNotes: RC dev checks emitted only expected local-environment warnings for missing release KataGo assets, signing evidence, Windows real-machine smoke evidence, and visual QA evidence. The actual v0.4.17 Windows portable packages were smoke-tested from the downloaded/extracted user assets and both passed with
katagoReady=true.