fix(cookies): verify against an age-restricted video (honest age status)#100
Merged
Conversation
The save-time check probed a normal video, so it could report "connected" while age-restricted playback still failed — the exact false-positive the user hit (#772 plays, #771 age-gates). Now verify_cookies probes a stable age-restricted video (HtVdAasjOgU) first: - resolves -> fully working; - age gate -> "cookies load but don't unlock age-restricted videos (account not age-verified, or cookies stale) — re-export from a signed-in browser"; - malformed/bot error -> surfaced verbatim; - age probe unavailable for an unrelated reason -> fall back to a normal video so a broken session is still caught. The result is recorded (set_cookies_error) so the panel shows it immediately on Save — no need to play a video to find out. 321 passed; ruff + mypy clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The save-time check probed a normal video, so it could say "connected" while age-restricted playback still failed — exactly the false-positive seen on the live server (#772 plays, #771 age-gates).
verify_cookiesnow probes a stable age-restricted video (HtVdAasjOgU) first:Recorded via
set_cookies_errorso the panel shows it immediately on Save — you can iterate exports until it says ✓ without playing a video each time.321 passed, ruff + mypy clean.
🤖 Generated with Claude Code