fix(cookies): cookie status reflects auth, not playback (stop false "invalid")#102
Merged
Merged
Conversation
…invalid") Two paths were wrongly marking valid cookies invalid once the android resolve went in (#101): - verify_cookies probed the *progressive resolve* (android client), which age-gates age-restricted videos even with good cookies -> save showed invalid. - the instant-stream resolve called note_extraction_error on its stderr; with android the age video age-gates ("confirm your age") and that flagged the cookies stale on every play attempt. Both conflate "is a progressive stream available" (a playback/SABR concern) with "do the cookies authenticate" (the age gate). Separate them: - _probe_error goes back to `--simulate` (no forced client/format): it checks the cookies pass the age gate, which is their actual job. - the instant-stream resolve no longer touches cookie status; validity is owned by the save-time verify. So valid cookies stay green even though age-restricted *playback* still fails on YouTube's SABR-only authenticated formats (separate issue; needs po_token or the download path). 321 passed; ruff + mypy clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #101, two paths wrongly marked valid cookies invalid:
verify_cookiesprobed the progressive resolve (android client) — which age-gates age-restricted videos even with good cookies → save showed invalid.note_extraction_erroron its stderr; with the android client an age video age-gates ("confirm your age"), flagging cookies stale on every play.Both conflate "is a progressive stream available" (a playback/SABR concern) with "do the cookies authenticate" (the age gate). Separated:
_probe_error→ back to--simulate(no forced client/format): checks the cookies pass the age gate, their actual job.Valid cookies now stay green. (Age-restricted playback still fails on YouTube's SABR-only authenticated formats — separate issue, needs po_token or the download path; tracked next.)
321 passed, ruff + mypy clean.
🤖 Generated with Claude Code