fix(download): use web/android clients — default ones downgrade to storyboards#106
Merged
Merged
Conversation
…oryboards The format dump (from #105) was conclusive: for an age-restricted video the default yt-dlp clients (tv, web_creator) get "downgraded" and return ONLY storyboard images (sb0-sb3) — no video/audio — so the preview/HQ download fail "Requested format is not available" even though cookies pass the age gate and the po_token is fetched. The web/android clients DO return the real (SABR adaptive) formats — which is why instant-stream got "format not available" (real formats, no progressive) rather than storyboards. The download path didn't pass player_client at all (used the default clients); splice in the same player_client_args() instant-stream already uses, on both download_video and download_preview (and the diagnostic -F). Age-restricted previews/downloads now see the real adaptive formats and can mux them. 321 passed; ruff clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The format dump from #105 was conclusive — for an age-restricted video, the default yt-dlp clients (tv, web_creator) get downgraded and return only storyboard images (
sb0–sb3), no video/audio:Cookies pass the age gate and the po_token is fetched — but those clients still won't yield media. The web/android clients return the real (SABR adaptive) formats (that's why instant-stream got "format not available" rather than storyboards).
The download path passed no
player_client(so it used the default clients). Fix: splice in the sameplayer_client_args()instant-stream already uses, ondownload_video,download_preview, and the diagnostic-F. Age-restricted previews/downloads now see the real adaptive formats and mux them.321 passed, ruff clean.
🤖 Generated with Claude Code