feat(channel): drop per-video "Remove from library" action#53
Merged
Conversation
Per-episode "remove from library" is collection-curation, which no longer fits the model: your library is your followed channels + watch-later, and you manage it by following/unfollowing (cache eviction handles space automatically). The per-video ⋯ menu is now watch-later only, matching tvOS. Removed the menu item and its confirm dialog (_confirmRemove). api_service. deleteVideo stays (still used by video_provider). 156 passed; analyze + format clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to the invisible-caching redesign (#52). Removes the per-video "Remove from library" action from the channel-detail ⋯ menu.
Per-episode "remove from library" is collection-curation, which no longer fits the model: your library is your followed channels + watch-later, and you manage it by following/unfollowing (cache eviction handles disk automatically). The ⋯ menu is now watch-later only, matching tvOS.
Changes
ListTileand its confirm dialog (_confirmRemove) fromchannel_detail_screen.dart.api_service.deleteVideois kept (still used byvideo_provider).Verification
flutter analyze --fatal-infos --fatal-warnings→ No issues,flutter test→ 156 passed.🤖 Generated with Claude Code