Clean up unit-system loose ends (dead code + duplicate alias table)#80
Merged
Conversation
Post-merge tidy of the unit-system engine. - Remove the unused units.Scale + roundCount (no caller — scaling is a future client concern; it returns with its consumer when the UI lands) and the half-wired cl/dl input units (the parser never produced them and measureKind misclassified them). - Unify the duplicate unit-alias table: the ingredient parser now resolves tokens through units.Canonical, and the service-local unitAliases copy is deleted. Single source of truth; parser tests unchanged and green. Full go test ./... green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-merge tidy of the unit-system engine — removing things I didn't want sitting in production.
units.Scale+roundCount(zero callers — server-side scaling is a future client concern and returns with its UI consumer) and the half-wiredcl/dlinput units (the parser never produced them andmeasureKindmisclassified them as imprecise).units.Canonical; the near-identical service-localunitAliasesmap is deleted. One source of truth.units.Canonicalis a content-superset, so parser behavior is unchanged (its tests pass untouched).Full
go test ./...green.Deliberately left
recipe.import.text/urlduplicate prompt blocks (dead but correct; not worth a fragile 28-line YAML match).-raceflake inTestFinishStreamedRecipe_BackgroundImageGeneration— it's a cross-test background-goroutine/global-S3-stub lifecycle issue in the streaming harness (the mock repo itself is already mutex-safe), unrelated to units and not run by the deploy gate. Worth a separate focused fix.🤖 Generated with Claude Code