v1 hardening: gate localhost WS origin behind a flag; document ID_HEADER#81
Merged
Conversation
- The cooking WebSocket CheckOrigin accepted any http://localhost origin unconditionally — dev convenience that should not be live in production. Gate it behind ALLOW_DEV_ORIGINS (defaults off) so prod rejects localhost browser origins. The socket is already token-authenticated; this is defense-in-depth. Test updated to cover both states. - Document ID_HEADER in .env.example (required shared secret that gates the API to the official client via the X-SaltyBytes-Identifier header) and add the new ALLOW_DEV_ORIGINS toggle. Full go test ./... green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two items from the v1 release audit.
CheckOriginaccepted anyhttp://localhost:*origin unconditionally — dev convenience that shouldn't be live in prod. Now gated behindALLOW_DEV_ORIGINS(defaults off), so production rejects localhost browser origins. The cooking socket is already token-authenticated (?token=), so this is defense-in-depth, not a fix for an open hole. The Flutter app sends noOriginand the prod domains stay whitelisted, so nothing user-facing changes.TestCheckOriginupdated to cover both states.ID_HEADERdocs: it's a required shared secret that gates the API to the official client (X-SaltyBytes-Identifier), but.env.exampleleft it blank and unexplained — an onboarding/fresh-deploy trap. Documented it, plus the newALLOW_DEV_ORIGINStoggle.Full
go test ./...green.Deliberately not changed
upgradeendpoint's 501 — the app depends on that exact response to show its "not yet available" message; changing the status/envelope would break it.🤖 Generated with Claude Code