Bundle a thumbnail for the screen saver list - #7
Merged
Merged
Conversation
Without one the list draws a generic spiral, which says nothing about what the saver is. A picture of the cat, mid-wander with prints behind it, says the whole thing at 90x58. Rendered by the preview app rather than drawn by hand, so it is the real thing: one cat on the plain grey backdrop, scratch marks off, and fast enough that the twelve seconds of paw prints it keeps cover some ground. `make thumbnail` regenerates both sizes from one 2x render. Where the cat ends up is down to where it wandered, so that target is worth running until you get one you like — this one is centred.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The screen saver list drew a generic spiral for NecoSaver, which says nothing
about what it is. It now ships a picture of the cat.
Resources/thumbnail.png(90x58) andResources/thumbnail@2x.png(180x116),copied into the bundle — the same convention Apple's own
Random.saveruses, andthe same one Macstify already had.
The picture
Rendered by the preview app rather than drawn by hand, so it is the real thing:
one cat on the plain grey backdrop, scratch marks off, and fast enough that the
twelve seconds of paw prints it keeps cover some ground.
make thumbnailregenerates both sizes from one 2x render. Where the cat ends upis down to where it wandered, so that target is worth running until you get one
you like — this one is centred.
Verified
Built and installed;
Contents/Resources/thumbnail.pngand@2xare in thebundle, and the list draws the cat.
One thing worth knowing if it ever looks like this change did nothing: the picker
caches these. A saver installed before it had a thumbnail leaves a placeholder
tile behind in
which survives a reboot, because it is keyed by content hash rather than
refreshed from the bundle. Deleting the stale entry and restarting
WallpaperAgentpicks the new one up. Not a problem for a fresh install.