Drop the grey level, and settle on black - #9
Merged
Merged
Conversation
A slider for how grey the empty backdrop is earns its row in the sheet only if someone wants a grey that is not black, and nobody does — the cat is black ink on a white body, which reads best on black, and every other value was a way to make it read worse. With no picture to draw, the backdrop is black. That takes a setting, its range, its stored key and its slider with it. The litter ink still reads the backdrop rather than assuming: over a picture it is measured as before, and over the plain black it comes out light, which is where the brightness of zero now leads. The preview app's `--grey` becomes `--no-picture`, since there is no grey left to ask for.
winebarrel
force-pushed
the
drop-grey-level
branch
from
August 10, 2026 06:01
7e0680f to
2ebf357
Compare
winebarrel
enabled auto-merge
August 10, 2026 06:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A slider for how grey the empty backdrop is earns its row in the sheet only if
someone wants a grey that is not black. The cat is black ink on a white body,
which reads best on black; every other value on that slider was a way to make it
read worse. With no picture to draw, the backdrop is now black, and the slider is
gone.
Options
What went
background,backgroundRange, its stored key, its entry in the registereddefaults, and its row in the sheet.
The litter ink still reads the backdrop rather than assuming one: over a picture
it is measured as before, and over the plain black it comes out light, which is
where a measured brightness of zero leads anyway.
The preview app's
--greybecomes--no-picture, since there is no grey left toask for.
Verified
Both schemes build and analyse;
swiftlint --strict,swiftlint analyze --strictand
swiftformat --lintare clean. Rendered the Options sheet (row gone, layoutstill square) and a frame with no picture (black, cats and prints legible on it).
Note
This touches the Options table in the README, which #8 also rewrites. Whichever
lands second will want a hand with the merge.