Fix build error on FreeBSD-AMD64#103
Merged
Merged
Conversation
billziss-gh
reviewed
May 18, 2026
| @@ -1,3 +1,4 @@ | |||
| //go:build darwin || freebsd || netbsd || openbsd || linux | |||
Collaborator
There was a problem hiding this comment.
Please remove. I understand that modern go tools change this automatically, but I would like minimal diffs.
| defer setuidgid()() | ||
| path = filepath.Join(self.root, path) | ||
| return errno(syscall.Mknod(path, mode, int(dev))) | ||
| errc = errno(syscall_Mknod(path, mode, dev)) |
Collaborator
There was a problem hiding this comment.
Please make this: return errno(syscall_Mknod(path, mode, dev))
| @@ -1,3 +1,4 @@ | |||
| //go:build darwin | |||
|
|
||
| func syscall_Mknod(path string, mode uint32, dev uint64) error { | ||
| return syscall.Mknod(path, mode, int(dev)) | ||
| } |
| @@ -1,3 +1,4 @@ | |||
| //go:build freebsd | |||
|
|
||
| func syscall_Mknod(path string, mode uint32, dev uint64) error { | ||
| return syscall.Mknod(path, mode, int(dev)) | ||
| } |
| @@ -1,3 +1,4 @@ | |||
| //go:build netbsd | |||
|
|
||
| func syscall_Mknod(path string, mode uint32, dev uint64) error { | ||
| return syscall.Mknod(path, mode, int(dev)) | ||
| } |
| @@ -1,3 +1,4 @@ | |||
| //go:build openbsd | |||
|
|
||
| func syscall_Mknod(path string, mode uint32, dev uint64) error { | ||
| return syscall.Mknod(path, mode, int(dev)) | ||
| } |
Collaborator
|
Can you please also squish all commits into a single one? |
Collaborator
|
Thank you. I have merged this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue #102 by adding syscall wrappers in port_*.go files