-
-
Notifications
You must be signed in to change notification settings - Fork 226
Added expand/collapse functionalities to relationship formwidget #1374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@damsfx ooo, I like this. And in Snowboard too! 😍 Couple of quick comments/questions:
|
Definitely yes! Despite this, a function written in jQuery is still called to update the scroll bar. :o(
The tree structure used for my tests and visible in the animation above contains 550 nodes spread over 4 levels of depth.
For sure. |
|
Latest update :
|
|
@damsfx don't be too concerned if you need to fall back on jQuery to do something in the Backend. A lot of the Backend still uses it and the goal of Snowboard was to remove the dependency of jQuery for the CMS side in particular. |
|
@bennothommo are you happy with this as it is? @damsfx is there a related docs PR? |
Not yet, but I can add a pending PR for this. |
Co-authored-by: Luke Towers <github@luketowers.ca>
@LukeTowers Done : wintercms/docs#243 |
|
@bennothommo I know your time is precious, but if you have 5 mins to take a look and give me a little feedback if you see any improvements to be made. |
|
@damsfx sorry for the delay. Looks great, and the timing of the animation is much better. Only issue I can see now is that it appears that some plugins and themes were added in your most recent commit: Could you make sure these are not included in your branch? Once that's done, @LukeTowers should be able to merge if he's happy with it. |
bennothommo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending removal of plugins and themes in recent commit
😱🙄 Oh, I was really distracted! Done ! |
This allow relation model with nested tree trait to display a expandable/collapsable list of checkboxes.
The field config allow two new options :