Draft
Conversation
istankovic
force-pushed
the
ivan/x509-part-5
branch
4 times, most recently
from
91ed66b to
7bbc86c
Compare
One problem was that we were creating two connections to the same database, one via the `ccInit` helper and another via a direct call to `openDatabase`, which meant that `teardown` waited a long time for the connections to drop (it would time out on CI). This has been worked around by using an new, unrelated database for the PKI environment. Another problem was usage patterns of the form `expect(expr == value)` rather than `expect(expr).toBe(value)`, which was causing checks to not do what they were supposed to do. So fix that too.
They are async.
Just like the crypto crate does.
They were only used for E2EI things, which has now been moved. Also make ed25519-dalek non-optional.
The function calls RustCrypto::normalize_p521_secret_key and RustCrypto::normalize_ed25519_key and the RustCrypto provider is not easily accessible from e2e-identity.
…:new PkiKeypair::new is supposed to be called immediately after having created a new signing key via signature_key_gen, and only with the private portion of the key pair. So instead of calling normalize, just make sure that the provided key has the right length. This also avoids the pointless copying.
Because MLS provider is defined in the crypto crate and we cannot depend on that crate in e2e-identity.
We're hitting the orphan rule here: Ciphersuite is defined in openmls, and JwsAlgorithm is defined in rusty-jwt-tools.
We're keeping E2eiConversationState for the time being.
We're going to need it.
It has been moved from crypto to e2e-identity.
istankovic
force-pushed
the
ivan/x509-part-5
branch
from
7bbc86c to
098191f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚧