Skip to content

fix(client): skip pretty on custom GET reads#94

Merged
desaintmartin merged 2 commits into
mainfrom
pretty
Mar 11, 2026
Merged

fix(client): skip pretty on custom GET reads#94
desaintmartin merged 2 commits into
mainfrom
pretty

Conversation

@desaintmartin

Copy link
Copy Markdown
Member

Prevent the client wrapper from forwarding shared read kwargs to CustomObjectsApi methods whose generated signatures reject them.

  • exclude pretty from custom-object GET-like methods only
  • keep pretty output on list methods that still support it
  • add regression tests for both behaviors and document why

Subagents-used: Explore
Skills-used: git-commit

Planned-by: GitHub Copilot / GPT-5.4 / 0.0
Built-by: GitHub Copilot / GPT-5.4 / 0.0

Prevent the client wrapper from forwarding shared read kwargs to
CustomObjectsApi methods whose generated signatures reject them.

- exclude `pretty` from custom-object GET-like methods only
- keep pretty output on list methods that still support it
- add regression tests for both behaviors and document why

Subagents-used: Explore
Skills-used: git-commit

Planned-by: GitHub Copilot / GPT-5.4 / 0.0
Built-by: GitHub Copilot / GPT-5.4 / 0.0
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.io>
@desaintmartin
desaintmartin force-pushed the pretty branch 6 times, most recently from 045a0eb to d4d998b Compare March 11, 2026 12:33
@desaintmartin
desaintmartin merged commit b7951e6 into main Mar 11, 2026
6 checks passed
@desaintmartin
desaintmartin deleted the pretty branch March 11, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant