Add INCLUDE_LOG to remove logs from build#155
Merged
Conversation
By default logs are included. INCLUDE_LOG 0 strips all logs from binary
GwendalRaoul
reviewed
Jun 4, 2026
| # define MAX_LOG_LEVEL ERROR_LOG_LEVEL | ||
| #endif | ||
|
|
||
| #if !defined(INCLUDE_LOG) |
Contributor
There was a problem hiding this comment.
What is the purpose of the flag?
Just a shortcut instead of defininig MAX_LOG_LEVEL to NO_LOG_LEVEL directly ?
CFLAGS += -DMAX_LOG_LEVEL =-1 wouldn't work directly?
Contributor
Author
There was a problem hiding this comment.
MAX_LOG_LEVEL is set by each file before including logger.h.
If I understand your proposal, MAX_LOG_LEVEL defined with cflags will be redefined, so it will not work, no ?
Contributor
There was a problem hiding this comment.
Ok, I missed this point!
GwendalRaoul
approved these changes
Jun 4, 2026
| # define MAX_LOG_LEVEL ERROR_LOG_LEVEL | ||
| #endif | ||
|
|
||
| #if !defined(INCLUDE_LOG) |
Contributor
There was a problem hiding this comment.
Ok, I missed this point!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.