upgrade actions to use latest version with node.js 24 support#184
upgrade actions to use latest version with node.js 24 support#184chriskarlin merged 11 commits intomainfrom
Conversation
chriskarlin
changed the title
There was a problem hiding this comment.
Pull request overview
Updates this repository’s composite GitHub Actions to newer upstream action versions (aimed at Node.js 24 compatibility) and migrates Buf setup to the newer buf-action, reducing Node deprecation warnings for downstream consumers.
Changes:
- Bump core GitHub Actions dependencies (checkout/cache/upload/download-artifact, AWS credentials, golangci-lint-action).
- Migrate Buf setup from
bufbuild/buf-setup-action@v1tobufbuild/buf-action@v1(setup-only), and adjust auth inputs. - Upgrade DataDog synthetics action and update input names to hyphenated form.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
ruby/test/action.yml |
Bumps actions/upload-artifact to v6 for Ruby test artifacts. |
ruby/one-for-all/action.yml |
Bumps actions/download-artifact to v7 to fetch test reports. |
ruby/lint/action.yml |
Bumps actions/upload-artifact to v6 for rubocop output. |
ruby/deps/action.yml |
Bumps actions/cache to v5; updates workspace cache action reference. |
go/test/action.yml |
Bumps actions/upload-artifact to v6 for Go test/coverage artifacts. |
go/smoke-test/action.yml |
Upgrades DataDog synthetics action to v4.0.0 and updates input names; updates cache action reference. |
go/lint/action.yml |
Updates internal Go action references; bumps golangci/golangci-lint-action to v9. |
go/deps/action.yml |
Bumps actions/cache to v5 and updates workspace cache action reference. |
go/configure/action.yml |
Bumps checkout to v6; migrates Buf setup to bufbuild/buf-action@v1 with setup_only. |
go/build/action.yml |
Updates internal Go action references. |
go/build-and-test/action.yml |
Updates internal Go action references. |
deploy/lambda/go/action.yml |
Bumps checkout to v6; updates workspace cache action reference. |
deploy/eks/action.yml |
Bumps AWS credentials action to v6 and checkout to v6; updates workspace cache action reference. |
cache/action.yml |
Bumps actions/cache to v5. |
.github/workflows/test.yml |
Bumps checkout to v6 in CI workflows. |
.github/workflows/main-version-update.yml |
Bumps checkout to v6 in release/tag workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| github_token: ${{ inputs.FLIPPCIRCLECIPULLER_REPO_TOKEN }} | ||
| buf_user: ${{ inputs.BUF_BUILD_USER }} | ||
| buf_api_token: ${{ inputs.BUF_BUILD_API_TOKEN }} | ||
| token: ${{ inputs.BUF_BUILD_API_TOKEN }} |
There was a problem hiding this comment.
I see your build passed, but want to be sure; the new version just doesn't need a user. Token only works?
There was a problem hiding this comment.
Yep seems to work as per success.
Docs also indicate token only is needed https://buf.build/docs/bsr/ci-cd/github-actions/#authentication-and-bsr-tokens
dcbickfo
left a comment
dcbickfo
left a comment
There was a problem hiding this comment.
Approved pending buf question.
chriskarlin
changed the title
Summary
actions/checkoutv4 → v6,actions/cachev4 → v5,actions/upload-artifactv4 → v6, andactions/download-artifactv4 → v7 across all actions to resolve Node.js 20 deprecation warningsaws-actions/configure-aws-credentialsv4 → v6 (Node.js 24)DataDog/synthetics-ci-github-actionv1.17.0 → v4.0.0 (Node.js 24). Input names changed from underscores to hyphens (api_key→api-key,app_key→app-key,public_ids→public-ids)bufbuild/buf-setup-action@v1tobufbuild/buf-action@v1withsetup_only: trueingo/configure. Auth inputs consolidated frombuf_user/buf_api_tokento the unifiedtokeninput. Two-step conditional pattern preserved: pinned version from.tool-versionswhen available, otherwise buf-action resolves its default.BUF_BUILD_USERinput kept for backward compatibility but marked as deprecatedgolangci/golangci-lint-actionv7 → v9 (Node.js 24) for the v2 config pathActions updated
actions/checkoutactions/cacheactions/upload-artifactactions/download-artifactaws-actions/configure-aws-credentialsDataDog/synthetics-ci-github-actionbufbuild/buf-setup-actionbuf-setup-action@v1buf-action@v1golangci/golangci-lint-actionKnown remaining Node.js 20 actions
golangci/golangci-lint-action@v6— no Node.js 24 version available for v1 config users; consumers need to migrate to golangci-lint v2 configslackapi/slack-github-action@v1.27.1— v3 available but has major breaking changes (channel-id input removed, token handling restructured, method input required). Separate PR neededTest plan
Go consumer: PR -> https://github.com/wishabi/distribution-api/actions/runs/23450402474
go/lint→ exercisesgo/configure(checkout v6, buf-action v1) +go/deps(cache v5) +golangci-lint-actionv9go/build→ exercisesgo/configure+go/depsgo/test→ exercises upload-artifact v6deploy/eks→ exercises checkout v6 + cache v5go/smoke-test→ exercises cache v5Ruby consumer: PR -> https://github.com/wishabi/geo-admin/actions/runs/23451615350
ruby/deps→ exercises cache v5ruby/lint→ exercises upload-artifact v6ruby/one-for-allruby/validation/topicruby/validation/schemacache→ exercises cache v5deploy/eks→ exercises checkout v6