Skip to content

Person#shortname: Remove (academic) titles for the short version of the ... #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stapelberg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Person#shortname: Remove (academic) titles for the short version of the ... #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions lib/turnsole/models.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,16 @@ def eql? o; o.email == @email end
attr_reader :name, :email, :handle

def shortname
case @name
return @handle if !@name
# Remove (academic) titles for the short version of the name.
stripped_name = @name
['Dr', 'Prof', 'Mr', 'Mrs', 'Ms'].each do |title|
stripped_name = stripped_name.gsub(/#{title}.?\s/, '')
end
case stripped_name
when /\S+, (\S+)/; $1
when /(\S+) \S+/; $1
when nil; @handle
else @name
else stripped_name
end
end

Expand Down