dirty workaround found(?) for bug with oneOf validation

[LukasGoTom]

Describe the bug
workaround fix here: 5abb006

the issue will probably remain if its a merged property?

oneOf: validator tries to hand over originalModelData to function to create $modifiedValues. But the function expects the argument to be of type array, leading to a php runtime exception.

it's about this code:

$modifiedValues = array_merge($modifiedValues, $this->{{ modifiedValuesMethod }}($originalModelData, $value));

Expected behavior
Well no runtime exception. Optimally understand why the runtime exception happens.

Schema

{
    "$schema": "http://json-schema.org/draft-07/schema#",
    "$id": "/schemas/core/product.json",
    "title": "Product",
    "description": "Represents available advertising inventory",
    "type": "object",
    "properties": {
        "pricing_options": {
            "type": "array",
            "description": "Available pricing models for this product",
            "items": {
                "oneOf": [
                    {
                        "type": "object",
                        "properties": {
                            "min_spend_per_package": {
                                "type": "number",
                                "description": "Minimum spend requirement per package using this pricing option, in the specified currency",
                                "minimum": 0
                            }
                        }
                    },
                    {
                        "type": "object",
                        "properties": {
                            "pricing_option_id": {
                                "type": "string",
                                "description": "Unique identifier for this pricing option within the product (e.g., 'cpm_usd_auction')"
                            }
                        }
                    }
                ]
            },
            "minItems": 1
        }
    }
}

Additionally include custom GeneratorConfiguration settings.

    public function test_oneof_bug(): void
    {
        $namespace = 'Tests\Dto\Generator\WolSoft\ResultOneOfBug';
        $generator = new ModelGenerator(
            (new GeneratorConfiguration())
                ->setNamespacePrefix($namespace)
                ->setImmutable(false)
                ->addFormat('date', new AlwaysHappyValidator())
        );

        $file = __DIR__ . '/bugOneOf';
        $resultDir = __DIR__ . '/ResultOneOfBug';
        $generator->addPostProcessor(new BuilderClassPostProcessor());

        $generator
            ->generateModelDirectory($resultDir)
       

Version:
the improveRef one

[wol-soft]

Which runtime exception are you facing? The generation of the provided schema works for me on the improveRefResolving branch as expected. Also providing data via the builder is working. An issue I'm facing is, that the schema will fail in many cases as both branches are valid except you violate explicitly the rules for pricing_option_id or min_spend_per_package.

The issue #102 is also not valid, as you are indeed able to provide a builder instance to the setter of a builder. Those are recursively resolved during the validation of the builder into the target object instance.

Note: with even more nested layers the recursion has an issue tho. I'll provide a fix for that.

[LukasGoTom]

the runtime exception is related to originalModelData "must be of type array" Some\Namespace\Class given... if you cant reproduce I will create a new test case for you as I can. Because I face the issue again now with GetProductsRequest, this payload:

{
    "brief": "some brief",
    "brand_manifest": {
        "name": "some cool brandname",
        "logos": [],
        "colors": [],
        "fonts": {
            "font_urls": []
        },
        "assets": [],
        "product_catalog": {
            "feed_url": "https://feedurl.com",
            "feed_format": "google_merchant_center",
            "categories": []
        },
        "disclaimers": [],
        "contact": [],
        "metadata": []
    },
    "filters": {
        "delivery_type": "guaranteed",
        "is_fixed_price": true,
        "format_types": [],
        "format_ids": [],
        "budget_range": {
            "min": 12,
            "max": 12,
            "currency": "CHF"
        },
        "countries": [],
        "channels": []
    },
    "context": [],
    "ext": []
}

output was after fixing another issue with composed properties:

TypeError: goTom\AdcpMcp\Dto\Adcp\MediaBuy\GetProductsRequest\GetProductsRequest_ProductFilters::_getModifiedValues_9e389(): Argument #1 ($originalModelData) must be of type array, goTom\AdcpMcp\Dto\Adcp\MediaBuy\GetProductsRequest\GetProductsRequest_Budget_range_4 given, called in /app/src/Dto/Adcp/MediaBuy/GetProductsRequest/GetProductsRequest_ProductFilters.php on line 999
/app/src/Dto/Adcp/MediaBuy/GetProductsRequest/GetProductsRequest_ProductFilters.php:1234
/app/src/Dto/Adcp/MediaBuy/GetProductsRequest/GetProductsRequest_ProductFilters.php:999
/app/src/Dto/Adcp/MediaBuy/GetProductsRequest/GetProductsRequest_ProductFilters.php:1109
/app/src/Dto/Adcp/MediaBuy/GetProductsRequest/GetProductsRequest_ProductFilters.php:679
/app/src/Dto/Adcp/MediaBuy/GetProductsRequest/GetProductsRequest_ProductFilters.php:657
/app/src/Dto/Adcp/MediaBuy/GetProductsRequest/GetProductsRequest_ProductFilters.php:114
/app/src/Dto/Adcp/MediaBuy/GetProductsRequest/GetProductsRequest.php:246
/app/src/Dto/Adcp/MediaBuy/GetProductsRequest/GetProductsRequest.php:258
/app/src/Dto/Adcp/MediaBuy/GetProductsRequest/GetProductsRequest.php:78
/app/tests/goTom/AdcpMcp/Tools/AdCP/GetProductsTest.php:166

currently my workaround is this 9b132d7

fix for composed properties and
bbabe76

both highly experimental.... toArray obviously only works if serialization is activated (which it is for my case)

i can give you full example with payload and schemas, but will take some time

[LukasGoTom]

i think the issue can be solved differently (not 100% sure though) by returning if its an object. The code that causes the issue is this:

    /**
     * Execute all validators for the property budgetRange
     */
    protected function validateBudgetRange($value, array $modelData)
    {
        if (!is_object($value)) {
            $this->_errorRegistry->addError(new \PHPModelGenerator\Exception\Generic\InvalidTypeException($value ?? null, ... [
                0 => 'budget_range',
                1 => 'object',
            ]));
        }

        if (is_object($value) && !($value instanceof \Exception) && !($value instanceof GetProductsRequest_Budget_range_4)) {
            $this->_errorRegistry->addError(new \PHPModelGenerator\Exception\Object\InvalidInstanceOfException($value ?? null, ... [
                0 => 'budget_range',
                1 => 'GetProductsRequest_Budget_range_4',
            ]));
        }
// <-------------------------- at this point $value must be a valid GetProductsRequest_Budget_range_4 object, yet we still call validateBudgetRange_ComposedProperty_5767d156e16ee5a665cce13cdde85928 which hands in value as a reference and changes it to one of the composed properties. Which causes all the bugs with "expected array got object". The composed objects do not represent the data handed in either, in this case currency for example is missing.
        $this->validateBudgetRange_ComposedProperty_5767d156e16ee5a665cce13cdde85928($value, $modelData);

        return $value;
    }

[wol-soft]

@LukasGoTom, I was not able to reproduce the type error but covered some test cases and the patch for #98 seemed to help here too. You can give the current master a shot, it includes all fixes regarding compositions