[ADC-690] Prove multiphysics diagnostics and fail-closed layouts - #637
Draft
wolf75222 wants to merge 5 commits into
Draft
[ADC-690] Prove multiphysics diagnostics and fail-closed layouts#637wolf75222 wants to merge 5 commits into
wolf75222 wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
origin/masterexplicitly, preserving the three existing ADC-690 commits and their historyLayoutPlanBuilderAPI and fail closed when the required ion-to-field mapping has no providerUser impact
The canonical multiphysics example now demonstrates both sides of the public contract: an invalid cross-layout coupling is rejected before state/effects can publish, while the valid same-layout transport/Poisson/collision case retains its existing HDF5, ParaView, checkpoint, and restart route. There is no provider substitution or compatibility fallback.
Current-head validation
docs/check_docs.pypassed with one existing freshness warninggit diff --checkpassedExplicit remaining work / non-claims
EXEMPLE_SPEC_FINALE_MULTIPHYSIQUE_CORE.pyhave not yet been rerun on this merged headunspecifiedmarkerADC-690 therefore remains In Progress and this PR remains draft.