fix(codegen): bind qualified flux provider packs (ADC-682) - #641
Draft
wolf75222 wants to merge 2 commits into
Draft
fix(codegen): bind qualified flux provider packs (ADC-682)#641wolf75222 wants to merge 2 commits into
wolf75222 wants to merge 2 commits into
Conversation
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-audit result
ADC-682 is not fully complete on current
origin/master, despite its Linear status. This draft closes a bounded source/compiler-provider slice only.What this changes
ComponentProviderPackscontract for bothModelandModulecompilation routes;model._m), not only to the public facade;The commit history is intentionally thematic:
61bd2f3a— production implementation;d7b34014— focused qualification and regression proofs.Validation
git diff --check: cleanNo shared build or install was modified. Native-extension tests that require a loaded source
_popscontract were intentionally not claimed in this isolated source-only lane.Explicitly still open in ADC-682
PhysicalFluxViewstill reconstructs the legacy globalAuxobject, including positional/global extra slots;flux_provider_requirements;Therefore this PR must not auto-close ADC-682. It is a source-only, fail-closed foundation for the remaining native cutover.