ADC-694: complete the generic HyQMOM15 closure and transaction proof - #645
Draft
wolf75222 wants to merge 9 commits into
Draft
ADC-694: complete the generic HyQMOM15 closure and transaction proof#645wolf75222 wants to merge 9 commits into
wolf75222 wants to merge 9 commits into
Conversation
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-audit result
The earlier corrective slice closed the missing particle-number diagnostic. After merging current
master(de3f6b56) explicitly, a second criterion-level audit found two remaining source gaps:@closure(4)value;What changed
@closure(4)decorator;LocalClosuretoHyQMOM15.vlasov_lorentz(closure=...), so its symbolic arithmetic is folded into the ordinary model/flux graph;HyQMOM15Closureoracle;Genericity and history
The closure uses the existing generic
LocalClosureauthoring boundary and the existingHyQMOM15.vlasov_lorentz(closure=...)option. No model-name dispatch, bespoke native category, callback in the hot path, compatibility alias, or alternate lifecycle was added.Current
masterwas integrated with an explicit merge commit; the example, transaction proof, tests, and documentation remain separate thematic commits.Source validation
10 passed— HyQMOM15 final contract;17 passed— final-release gate and release contract;41 passed— descriptor protocol, moment descriptors, and final public API;py_compilepassed for the executable and affected tests;docs/check_docs.pypassed for 41 Markdown files and 11 docmap entries, with one non-fatal freshness warning because the reviewed final specification depends on the modified example;git diff --check origin/master...HEADpassed and the worktree is clean.Explicit non-claims
No native rebuild/install, direct installed-package execution of the updated script,
ctest, HDF5/ParaView reopen, checkpoint/restart execution, MPI, OpenMP, or GPU run was performed for this new head; those belong to the shared ADC-687 build lane. The older green CI run is historical evidence, not proof of these new commits.The executable acceptance test is intentionally an installed-package test. Running it with
PYTHONPATH=pythonhidespops._pops, makes the communicatorunknown, and is refused before compilation rather than silently selectingSERIAL. The installed lane must run it after build/install withPYTHONPATHunset.This Uniform example has no non-empty AMR reflux ledger. It authenticates ownership of the generic
flux_ledgersprovisional store, while non-empty multilevel ledger persistence is exercised by the dedicated AMR final example.