refactor(output): make collective HDF5 observer-lane owned (ADC-683) - #646
Draft
wolf75222 wants to merge 3 commits into
Draft
Conversation
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
This draft PR is stacked on #643 at commit 0ac4942. It preserves three separate thematic commits:
What changes
The retained HDF5 mutex is intentional encapsulation of HDF5 library-global/thread-safety behavior. It is not communicator discovery or borrowed simulation state.
The touched HDF5 C++ implementation was normalized by clang-format, which accounts for most of the line-count churn; the semantic change remains limited to communicator ownership and capability discovery.
Validation
No shared build or install was modified.
Explicit non-claims